Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2705753002: Resume the main job immediately when QUIC job fails, not wait for the (Closed)

Created:
3 years, 10 months ago by Zhongyi Shi
Modified:
3 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Reland the code with fixed depency in unittests. Resume the main job immediately when QUIC job fails, not wait for the head start timer to exprie BUG=691688 Review-Url: https://codereview.chromium.org/2693043008 Cr-Commit-Position: refs/heads/master@{#450705} (cherry picked from commit ff2bfbfd76f3c43e5618addd34c82fed42d2a6f5) R=rch@chromium.org Review-Url: https://codereview.chromium.org/2705753002 . Cr-Commit-Position: refs/branch-heads/2987@{#585} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/ecda574641950e9fa2902aeb4bf1aac97843ad2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -6 lines) Patch
M net/http/http_stream_factory_impl_job_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 3 chunks +16 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 1 chunk +72 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_test_util.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Zhongyi Shi
3 years, 10 months ago (2017-02-18 00:02:53 UTC) #3
Ryan Hamilton
lgtm *fingers crossed*
3 years, 10 months ago (2017-02-18 00:04:18 UTC) #4
Zhongyi Shi
3 years, 10 months ago (2017-02-18 00:06:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ecda574641950e9fa2902aeb4bf1aac97843ad2c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698