ozone: Don't assume AddFB succeeds when importing buffers.

ozone: Don't assume AddFB succeeds when importing buffers.

For buffers bigger than a certain threshold adding an FB can fail.
The current code fails to create an image and to import the buffer
in these cases.

After this CL a buffer import will succeed even if an FB can't be added.

BUG=b/33247171

Review-Url: https://codereview.chromium.org/2705733003
Cr-Commit-Position: refs/heads/master@{#451772}
Committed: https://chromium.googlesource.com/chromium/src/+/50300662aaabfdd6a5a7d458b8cc344ecd41ab1b

[Daniele Castagna, 2017-02-17 23:50:50]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 23:52:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2017-02-18 00:02:53]

dcastagna@chromium.org changed reviewers:
+ dnicoara@chromium.org, reveman@chromium.org, spang@chromium.org

[Daniele Castagna, 2017-02-18 00:02:54]

Alright, this is a tentative CL to follow up to crrev.com/2685833002 and
crrev.com/2699693003

The difference between this CL and the original crrev.com/2685833002 that has
been rejected is that with this CL we're still failing to allocate a buffer if
the usage is SCANOUT and a fb can't be added.

In this CL we succeed to *import* a buffer from fds even if a fb can't be added
for that buffer.
When we import a buffer we're not specifying a usage now, so we're not breaking
any contract in that case.

WDYT?

[reveman, 2017-02-18 00:04:54]

I think this is a good short term fix that is not scary to merge back. lgtm.

[Daniele Castagna, 2017-02-18 00:13:32]

Description was changed from

==========
ozone: Don't assume AddFB succeeds when importing buffers.

For buffers bigger than a certain threshold adding a FB can fail.
The current code fails to create an image and to import the buffer
in these cases.

After this CL a buffer import will succeed even if an FB can't be added.

BUG=b/33247171
==========

to

==========
ozone: Don't assume AddFB succeeds when importing buffers.

For buffers bigger than a certain threshold adding an FB can fail.
The current code fails to create an image and to import the buffer
in these cases.

After this CL a buffer import will succeed even if an FB can't be added.

BUG=b/33247171
==========

[commit-bot: I haz the power, 2017-02-18 01:56:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:56:12]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Daniele Castagna, 2017-02-18 02:45:17]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-18 02:45:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 04:34:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 04:34:23]

Dry run: This issue passed the CQ dry run.

[dnicoara, 2017-02-21 15:32:01]

lgtm ... I agree, restricting this to just the buffer import case is fine since
the API doesn't specify a usage.

[Daniele Castagna, 2017-02-21 15:45:53]

The CQ bit was checked by dcastagna@chromium.org

[commit-bot: I haz the power, 2017-02-21 15:46:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 16:13:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487691953555840, "parent_rev":
"c51531ca429e54478b286186091d83a7419ce05f", "commit_rev":
"50300662aaabfdd6a5a7d458b8cc344ecd41ab1b"}

[commit-bot: I haz the power, 2017-02-21 16:14:25]

Description was changed from

==========
ozone: Don't assume AddFB succeeds when importing buffers.

For buffers bigger than a certain threshold adding an FB can fail.
The current code fails to create an image and to import the buffer
in these cases.

After this CL a buffer import will succeed even if an FB can't be added.

BUG=b/33247171
==========

to

==========
ozone: Don't assume AddFB succeeds when importing buffers.

For buffers bigger than a certain threshold adding an FB can fail.
The current code fails to create an image and to import the buffer
in these cases.

After this CL a buffer import will succeed even if an FB can't be added.

BUG=b/33247171

Review-Url: https://codereview.chromium.org/2705733003
Cr-Commit-Position: refs/heads/master@{#451772}
Committed:
https://chromium.googlesource.com/chromium/src/+/50300662aaabfdd6a5a7d458b8cc...
==========

[commit-bot: I haz the power, 2017-02-21 16:14:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/50300662aaabfdd6a5a7d458b8cc...