Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4233)

Unified Diff: chrome/browser/extensions/extension_install_prompt.h

Issue 2705733002: [Extensions] Deprecate old install prompt types (Closed)
Patch Set: lazyboy's Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/extensions/extension_install_prompt.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_install_prompt.h
diff --git a/chrome/browser/extensions/extension_install_prompt.h b/chrome/browser/extensions/extension_install_prompt.h
index 20d093891026db1280f709d11d2f72ec3a2955ce..3079697f26326f9722406922c0db34ebb51ffb2a 100644
--- a/chrome/browser/extensions/extension_install_prompt.h
+++ b/chrome/browser/extensions/extension_install_prompt.h
@@ -54,18 +54,18 @@ class ExtensionInstallPrompt {
enum PromptType {
UNSET_PROMPT_TYPE = -1,
INSTALL_PROMPT = 0,
- INLINE_INSTALL_PROMPT,
- BUNDLE_INSTALL_PROMPT_DEPRECATED,
- RE_ENABLE_PROMPT,
- PERMISSIONS_PROMPT,
- EXTERNAL_INSTALL_PROMPT,
- POST_INSTALL_PERMISSIONS_PROMPT,
- LAUNCH_PROMPT_DEPRECATED,
- REMOTE_INSTALL_PROMPT,
- REPAIR_PROMPT,
- DELEGATED_PERMISSIONS_PROMPT,
- DELEGATED_BUNDLE_PERMISSIONS_PROMPT_DEPRECATED,
- NUM_PROMPT_TYPES
+ INLINE_INSTALL_PROMPT = 1,
+ // BUNDLE_INSTALL_PROMPT_DEPRECATED = 2,
+ RE_ENABLE_PROMPT = 3,
+ PERMISSIONS_PROMPT = 4,
+ EXTERNAL_INSTALL_PROMPT = 5,
+ POST_INSTALL_PERMISSIONS_PROMPT = 6,
+ // LAUNCH_PROMPT_DEPRECATED = 7,
+ REMOTE_INSTALL_PROMPT = 8,
+ REPAIR_PROMPT = 9,
+ DELEGATED_PERMISSIONS_PROMPT = 10,
+ // DELEGATED_BUNDLE_PERMISSIONS_PROMPT_DEPRECATED = 11,
+ NUM_PROMPT_TYPES = 12,
};
// The last prompt type to display; only used for testing.
@@ -109,7 +109,6 @@ class ExtensionInstallPrompt {
int rating_count);
PromptType type() const { return type_; }
- void set_type(PromptType type) { type_ = type; }
// Getters for UI element labels.
base::string16 GetDialogTitle() const;
@@ -199,7 +198,7 @@ class ExtensionInstallPrompt {
bool ShouldDisplayRevokeFilesButton() const;
- PromptType type_;
+ const PromptType type_;
// Permissions that are being requested (may not be all of an extension's
// permissions if only additional ones are being requested)
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/extensions/extension_install_prompt.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698