[Extensions] Deprecate old install prompt types

chrome/browser/extensions/extension_install_prompt.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_
 
 #include <stddef.h>
 
 #include <memory>
@@ skipping 36 matching lines @@
 }
 
 // Displays all the UI around extension installation.
 class ExtensionInstallPrompt {
  public:
   // This enum is associated with Extensions.InstallPrompt_Type UMA histogram.
   // Do not modify existing values and add new values only to the end.
   enum PromptType {
     UNSET_PROMPT_TYPE = -1,
     INSTALL_PROMPT = 0,
-    INLINE_INSTALL_PROMPT,
-    BUNDLE_INSTALL_PROMPT_DEPRECATED,
-    RE_ENABLE_PROMPT,
-    PERMISSIONS_PROMPT,
-    EXTERNAL_INSTALL_PROMPT,
-    POST_INSTALL_PERMISSIONS_PROMPT,
-    LAUNCH_PROMPT_DEPRECATED,
-    REMOTE_INSTALL_PROMPT,
-    REPAIR_PROMPT,
-    DELEGATED_PERMISSIONS_PROMPT,
-    DELEGATED_BUNDLE_PERMISSIONS_PROMPT_DEPRECATED,
-    NUM_PROMPT_TYPES
+    INLINE_INSTALL_PROMPT = 1,
+    // BUNDLE_INSTALL_PROMPT_DEPRECATED = 2,
+    RE_ENABLE_PROMPT = 3,
+    PERMISSIONS_PROMPT = 4,
+    EXTERNAL_INSTALL_PROMPT = 5,
+    POST_INSTALL_PERMISSIONS_PROMPT = 6,
+    // LAUNCH_PROMPT_DEPRECATED = 7,
+    REMOTE_INSTALL_PROMPT = 8,
+    REPAIR_PROMPT = 9,
+    DELEGATED_PERMISSIONS_PROMPT = 10,
+    // DELEGATED_BUNDLE_PERMISSIONS_PROMPT_DEPRECATED = 11,
+    NUM_PROMPT_TYPES = 12,
   };
 
   // The last prompt type to display; only used for testing.
   static PromptType g_last_prompt_type_for_tests;
 
   // Enumeration for permissions and retained files details.
   enum DetailsType {
     PERMISSIONS_DETAILS = 0,
     WITHHELD_PERMISSIONS_DETAILS,
     RETAINED_FILES_DETAILS,
@@ skipping 23 matching lines @@
                         PermissionsType permissions_type);
     void SetIsShowingDetails(DetailsType type,
                              size_t index,
                              bool is_showing_details);
     void SetWebstoreData(const std::string& localized_user_count,
                          bool show_user_count,
                          double average_rating,
                          int rating_count);
 
     PromptType type() const { return type_; }
-    void set_type(PromptType type) { type_ = type; }
 
     // Getters for UI element labels.
     base::string16 GetDialogTitle() const;
     int GetDialogButtons() const;
     // Returns the empty string when there should be no "accept" button.
     base::string16 GetAcceptButtonLabel() const;
     base::string16 GetAbortButtonLabel() const;
     base::string16 GetPermissionsHeading(
         PermissionsType permissions_type) const;
     base::string16 GetRetainedFilesHeading() const;
@@ skipping 69 matching lines @@
 
     // Returns the InstallPromptPermissions corresponding to
     // |permissions_type|.
     InstallPromptPermissions& GetPermissionsForType(
         PermissionsType permissions_type);
     const InstallPromptPermissions& GetPermissionsForType(
         PermissionsType permissions_type) const;
 
     bool ShouldDisplayRevokeFilesButton() const;
 
-    PromptType type_;
+    const PromptType type_;
 
     // Permissions that are being requested (may not be all of an extension's
     // permissions if only additional ones are being requested)
     InstallPromptPermissions prompt_permissions_;
     // Permissions that will be withheld upon install.
     InstallPromptPermissions withheld_prompt_permissions_;
 
     bool is_showing_details_for_retained_files_;
     bool is_showing_details_for_retained_devices_;
 
@@ skipping 170 matching lines @@
 
   // Whether or not the |show_dialog_callback_| was called.
   bool did_call_show_dialog_;
 
   base::WeakPtrFactory<ExtensionInstallPrompt> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionInstallPrompt);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_