Convert SkiaBitLocker to use PaintCanvas

Convert SkiaBitLocker to use PaintCanvas

SkiaBitLocker currently operates on SkCanvas, but is only used as a
helper for recording mac scrollbars.  As a part of changing out the
backend of how recordings are stored, this SkCanvas will be changed to
cc::PaintCanvas.

As this class is no longer dealing with Skia objects, rename it to
GraphicsContextCanvas and move it and its tests to platform/mac as there
is only one class that uses it.

This will allow this code to continue working when cc::PaintCanvas
is not a typedef to SkCanvas and is a separate concrete class.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2705723002
Cr-Commit-Position: refs/heads/master@{#452938}
Committed: https://chromium.googlesource.com/chromium/src/+/7e40b4199bd624399e821ac4dc7d0bcf2980d7b1

[enne (OOO), 2017-02-17 23:10:55]

Description was changed from

==========
Convert SkiaBitLocker to use PaintCanvas

SkiaBitLocker currently operates on SkCanvas, but is only used as a
helper for recording mac scrollbars.  As a part of changing out the
backend of how recordings are stored, this SkCanvas will be changed to
cc::PaintCanvas.

As this class is no longer dealing with Skia objects, rename it to
GraphicsContextCanvas and move it and its tests to platform/mac as there
is only one class that uses it.

This will allow this code to continue working when cc::PaintCanvas
is not a typedef to SkCanvas and is a separate concrete class.

BUG=671433
==========

to

==========
Convert SkiaBitLocker to use PaintCanvas

SkiaBitLocker currently operates on SkCanvas, but is only used as a
helper for recording mac scrollbars.  As a part of changing out the
backend of how recordings are stored, this SkCanvas will be changed to
cc::PaintCanvas.

As this class is no longer dealing with Skia objects, rename it to
GraphicsContextCanvas and move it and its tests to platform/mac as there
is only one class that uses it.

This will allow this code to continue working when cc::PaintCanvas
is not a typedef to SkCanvas and is a separate concrete class.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[enne (OOO), 2017-02-17 23:11:28]

enne@chromium.org changed reviewers:
+ junov@chromium.org

[enne (OOO), 2017-02-17 23:12:52]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 23:14:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 01:17:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:17:42]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[enne (OOO), 2017-02-22 19:42:12]

(ping)

[enne (OOO), 2017-02-23 19:06:48]

enne@chromium.org changed reviewers:
+ ccameron@chromium.org

[enne (OOO), 2017-02-24 19:33:58]

junov, do you need me to find somebody else for this?

[Justin Novosad, 2017-02-24 19:47:59]

sorry for the delay.  lgtm

[enne (OOO), 2017-02-24 19:49:00]

No worries!  Thanks.  :)

[enne (OOO), 2017-02-24 19:49:04]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2017-02-24 19:50:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 21:50:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487965744492920,
"parent_rev": "2c407ccc88aae08641fcb667277df2b08a2f251a", "commit_rev":
"7e40b4199bd624399e821ac4dc7d0bcf2980d7b1"}

[commit-bot: I haz the power, 2017-02-24 21:51:01]

Description was changed from

==========
Convert SkiaBitLocker to use PaintCanvas

SkiaBitLocker currently operates on SkCanvas, but is only used as a
helper for recording mac scrollbars.  As a part of changing out the
backend of how recordings are stored, this SkCanvas will be changed to
cc::PaintCanvas.

As this class is no longer dealing with Skia objects, rename it to
GraphicsContextCanvas and move it and its tests to platform/mac as there
is only one class that uses it.

This will allow this code to continue working when cc::PaintCanvas
is not a typedef to SkCanvas and is a separate concrete class.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Convert SkiaBitLocker to use PaintCanvas

SkiaBitLocker currently operates on SkCanvas, but is only used as a
helper for recording mac scrollbars.  As a part of changing out the
backend of how recordings are stored, this SkCanvas will be changed to
cc::PaintCanvas.

As this class is no longer dealing with Skia objects, rename it to
GraphicsContextCanvas and move it and its tests to platform/mac as there
is only one class that uses it.

This will allow this code to continue working when cc::PaintCanvas
is not a typedef to SkCanvas and is a separate concrete class.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2705723002
Cr-Commit-Position: refs/heads/master@{#452938}
Committed:
https://chromium.googlesource.com/chromium/src/+/7e40b4199bd624399e821ac4dc7d...
==========

[commit-bot: I haz the power, 2017-02-24 21:51:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7e40b4199bd624399e821ac4dc7d...