Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2705703002: Revert of [Reland] Dont post delayed DoWork for disabled queues. (Closed)

Created:
3 years, 10 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 10 months ago
Reviewers:
haraken, jbudorick, Sami, altimin
CC:
chromium-reviews, blink-reviews, scheduler-bugs_chromium.org, altimin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Reland] Dont post delayed DoWork for disabled queues. (patchset #14 id:260001 of https://codereview.chromium.org/2572893002/ ) Reason for revert: Looks like there's still a bad interaction with the TaskQueueThrottler. https://bugs.chromium.org/p/chromium/issues/detail?id=693672 Original issue's description: > Dont post delayed DoWork for disabled queues. We could do this for > fences too but don't because that would break the throttling logic > which needs to know when the next delayed task is due to be run. > > Contains a fix for the bug which previously was causing renderer hangs. > > TaskQueue::GetNextScheduledWakeUp must return base::nullopt for > disabled queues because we no longer schedule wakeups for those. If we > don't do this then the TaskQueueThrottler will be fed misleading data > which causes it to misbehave. > > BUG=671669, 688422, 693672 > > Committed: https://crrev.com/cab9842ac55e5b9dab766f11c6e412949d854483 > Cr-Original-Original-Commit-Position: refs/heads/master@{#438962} > Review-Url: https://codereview.chromium.org/2572893002 > Cr-Original-Commit-Position: refs/heads/master@{#447591} > Committed: https://chromium.googlesource.com/chromium/src/+/9a8a61516e750796f74869167bb919a05551d4dd > Review-Url: https://codereview.chromium.org/2572893002 > Cr-Commit-Position: refs/heads/master@{#450679} > Committed: https://chromium.googlesource.com/chromium/src/+/c4b071b9088980c941d3dea85478b10675a479e6 TBR=skyostil@chromium.org,haraken@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=671669, 688422, 693672 Review-Url: https://codereview.chromium.org/2705703002 Cr-Commit-Position: refs/heads/master@{#451449} Committed: https://chromium.googlesource.com/chromium/src/+/469e3d5d1a527c19a07df597399abbe44b85aa0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -651 lines) Patch
M third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/real_time_domain.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc View 3 chunks +6 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h View 5 chunks +5 lines, -73 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc View 8 chunks +48 lines, -62 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_perftest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc View 18 chunks +48 lines, -305 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_selector_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain.h View 1 chunk +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc View 9 chunks +24 lines, -91 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/public/platform/scheduler/base/task_queue.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
alex clarke (OOO till 29th)
Created Revert of [Reland] Dont post delayed DoWork for disabled queues.
3 years, 10 months ago (2017-02-17 21:42:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705703002/1
3 years, 10 months ago (2017-02-17 21:43:59 UTC) #3
haraken
LGTM
3 years, 10 months ago (2017-02-17 22:52:31 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-17 23:47:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705703002/1
3 years, 10 months ago (2017-02-17 23:53:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/17748)
3 years, 10 months ago (2017-02-18 01:54:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705703002/1
3 years, 10 months ago (2017-02-18 04:18:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-18 06:19:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705703002/1
3 years, 10 months ago (2017-02-18 09:35:26 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 09:44:40 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/469e3d5d1a527c19a07df597399a...

Powered by Google App Engine
This is Rietveld 408576698