Removed CRWSessionEntry from CRWWebController.

ios/web/public/web_state/ui/crw_web_delegate.h

Index: ios/web/public/web_state/ui/crw_web_delegate.h
diff --git a/ios/web/public/web_state/ui/crw_web_delegate.h b/ios/web/public/web_state/ui/crw_web_delegate.h
index 638924497619f9425cfaaa86f33e43579fd04ca4..33d3f132da009bbfb37633c52fb31b66d562a8af 100644
--- a/ios/web/public/web_state/ui/crw_web_delegate.h
+++ b/ios/web/public/web_state/ui/crw_web_delegate.h
@@ -74,11 +74,8 @@ class GURL;
 - (void)webDidUpdateSessionForLoadWithParams:
             (const web::NavigationManager::WebLoadParams&)params
                         wasInitialNavigation:(BOOL)initialNavigation;
-// Called from finishHistoryNavigationFromEntry.
-// TODO(crbug.com/692331): Remove this method and use |DidFinishNavigation|.
-- (void)webWillFinishHistoryNavigationFromEntry:(CRWSessionEntry*)fromEntry;

[Eugene But (OOO till 7-30), 2017/03/02 22:49:41]

I think we still need this code for old back forward navigation.

[kkhorimoto, 2017/03/03 00:27:55]

Tab's implementation of this function only calls |notifyTabChanged:| on the
TabModel, but this will already be called due to the OnNavigationItemCommitted()
callback.

[Eugene But (OOO till 7-30), 2017/03/03 01:53:36]

|notifyTabChanged:| is definitely called for same-document navigation (probably
multiple times). But is it called for different-document navigations? Is there a
reason why you want to remove this callback now? It could be easily removed
after cleaning up "PendingIndexNavigationDisabled" experimental setting.

[kkhorimoto, 2017/03/08 21:31:33]

My main motivation for removing this was that A) it didn't serve any purpose
since |notifyTabChanged:| is already called, and B) it exposes a deprecated
private class in a public delegate protocol.  I've verified that
|notifyTabChanged:| is called numerous times for same- and different-document
navigations both when the experiment is disabled and enabled.  I considered just
leaving this as |-webWillFinishHistoryNavigation|, since |fromEntry| isn't
actually used in the implementation, but since it seems that this is not adding
anything, I just removed it for simplicity.

[kkhorimoto, 2017/03/08 22:18:38]

I've added this back in so that chrome is notified at the proper time for legacy
history navigations.

-// ---------------------------------------------------------------------
 
+// ---------------------------------------------------------------------
 // Called when |webController| wants to open a new window. |URL| is the URL of
 // the new window; |openerURL| is the URL of the page which requested a window
 // to be open; |initiatedByUser| is YES if action was caused by the user.