Removed CRWSessionEntry from CRWWebController.

ios/web/public/web_state/ui/crw_web_delegate.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_PUBLIC_WEB_STATE_UI_CRW_WEB_DELEGATE_H_
 #define IOS_WEB_PUBLIC_WEB_STATE_UI_CRW_WEB_DELEGATE_H_
 
 #include <stdint.h>
 #import <UIKit/UIKit.h>
 #include <vector>
@@ skipping 56 matching lines @@
 - (void)webWillReload;
 // Called when a page is loaded using loadWithParams.  In
 // |webWillInitiateLoadWithParams|, the |params| argument is non-const so that
 // the delegate can make changes if necessary.
 // TODO(rohitrao): This is not a great API.  Clean it up.
 - (void)webWillInitiateLoadWithParams:
     (web::NavigationManager::WebLoadParams&)params;
 - (void)webDidUpdateSessionForLoadWithParams:
             (const web::NavigationManager::WebLoadParams&)params
                         wasInitialNavigation:(BOOL)initialNavigation;
-// Called from finishHistoryNavigationFromEntry.
-// TODO(crbug.com/692331): Remove this method and use |DidFinishNavigation|.
-- (void)webWillFinishHistoryNavigationFromEntry:(CRWSessionEntry*)fromEntry;

[Eugene But (OOO till 7-30), 2017/03/02 22:49:41]

I think we still need this code for old back forward navigation.

[kkhorimoto, 2017/03/03 00:27:55]

Tab's implementation of this function only calls |notifyTabChanged:| on the
TabModel, but this will already be called due to the OnNavigationItemCommitted()
callback.

[Eugene But (OOO till 7-30), 2017/03/03 01:53:36]

|notifyTabChanged:| is definitely called for same-document navigation (probably
multiple times). But is it called for different-document navigations? Is there a
reason why you want to remove this callback now? It could be easily removed
after cleaning up "PendingIndexNavigationDisabled" experimental setting.

[kkhorimoto, 2017/03/08 21:31:33]

My main motivation for removing this was that A) it didn't serve any purpose
since |notifyTabChanged:| is already called, and B) it exposes a deprecated
private class in a public delegate protocol.  I've verified that
|notifyTabChanged:| is called numerous times for same- and different-document
navigations both when the experiment is disabled and enabled.  I considered just
leaving this as |-webWillFinishHistoryNavigation|, since |fromEntry| isn't
actually used in the implementation, but since it seems that this is not adding
anything, I just removed it for simplicity.

[kkhorimoto, 2017/03/08 22:18:38]

I've added this back in so that chrome is notified at the proper time for legacy
history navigations.

+
 // ---------------------------------------------------------------------
-
 // Called when |webController| wants to open a new window. |URL| is the URL of
 // the new window; |openerURL| is the URL of the page which requested a window
 // to be open; |initiatedByUser| is YES if action was caused by the user.
 // |webController| will not open a window if this method returns nil. This
 // method can not return |webController|.
 - (CRWWebController*)webController:(CRWWebController*)webController
          createWebControllerForURL:(const GURL&)URL
                          openerURL:(const GURL&)openerURL
                    initiatedByUser:(BOOL)initiatedByUser;
 
@@ skipping 49 matching lines @@
 // Called when a PassKit file is downloaded. |data| should be the data from a
 // PassKit file, but this is not guaranteed, and the delegate is responsible for
 // error handling non PassKit data using -[PKPass initWithData:error:]. If the
 // download does not successfully complete, |data| will be nil.
 - (void)webController:(CRWWebController*)webController
     didLoadPassKitObject:(NSData*)data;
 
 @end
 
 #endif  // IOS_WEB_PUBLIC_WEB_STATE_UI_CRW_WEB_DELEGATE_H_