Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2705653004: Use saturated arithmetic in NinePieceImageGrid to avoid overflow (Closed)

Created:
3 years, 10 months ago by pdr.
Modified:
3 years, 10 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, jfernandez, Manuel Rego, svillar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use saturated arithmetic in NinePieceImageGrid to avoid overflow This is a simple patch to avoid unnecessary overflow when adding widths together. BUG=693010 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2705653004 Cr-Commit-Position: refs/heads/master@{#451485} Committed: https://chromium.googlesource.com/chromium/src/+/9c78072f8bfee9cf61c42f3385d1ff9d7dab22a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/core/paint/NinePieceImageGrid.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
pdr.
Pretty sure this is the last open overflow bug on our team.
3 years, 10 months ago (2017-02-17 22:16:55 UTC) #3
chrishtr
lgtm
3 years, 10 months ago (2017-02-17 22:18:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705653004/1
3 years, 10 months ago (2017-02-17 22:19:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-18 00:23:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705653004/1
3 years, 10 months ago (2017-02-18 02:56:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/367801)
3 years, 10 months ago (2017-02-18 06:27:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705653004/1
3 years, 10 months ago (2017-02-18 18:30:28 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 19:05:38 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c78072f8bfee9cf61c42f3385d1...

Powered by Google App Engine
This is Rietveld 408576698