WebKit LayoutTests needs more resources.

WebKit LayoutTests needs more resources.

It needs the PerformanceTests directory. This should fix the following
failures;
 * fast/harness/perftests/perf-runner-compute-statistics.html
 * fast/harness/perftests/runs-per-second-iterations.html
 * fast/harness/perftests/runs-per-second-log.html
 * fast/harness/perftests/measure-frame-time.html
 * fast/harness/perftests/measure-time.html
Which are failing with;
 CONSOLE ERROR: line 66: Uncaught ReferenceError: PerfTestRunner is not
 defined

It needs the extracted devtools resources (bug https://crbug.com/693723
created for this). This should fix the following failures;
 * inspector-protocol/heap-profiler/heap-samples-in-snapshot.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-active-dom-object.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html
Which are failing with;
 TypeError: HeapSnapshotWorker.HeapSnapshotLoader is not a constructor

BUG=52475, 693723
NOTRY=true

Review-Url: https://codereview.chromium.org/2705653002
Cr-Commit-Position: refs/heads/master@{#451412}
Committed: https://chromium.googlesource.com/chromium/src/+/2bf83ac0e39afbe323a7afe1bd89386ebda50034

[mithro, 2017-02-17 19:46:51]

The CQ bit was checked by tansell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 19:48:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mithro, 2017-02-17 19:48:41]

tansell@chromium.org changed reviewers:
+ dpranke@google.com, jbudorick@chromium.org

[mithro, 2017-02-17 19:48:42]

Hi,

Another small tweak to the BUILD file for LayoutTests. Turns out they need the
PerformanceTests directory too.

Tim 'mithro' Ansell

[jbudorick, 2017-02-17 19:50:39]

lgtm

[commit-bot: I haz the power, 2017-02-17 20:38:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:38:41]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[mithro, 2017-02-17 21:05:01]

Description was changed from

==========
WebKit LayoutTests needs the PerformanceTests directory.

This should fix the following failures;
 * fast/harness/perftests/perf-runner-compute-statistics.html
 * fast/harness/perftests/runs-per-second-iterations.html
 * fast/harness/perftests/runs-per-second-log.html
 * fast/harness/perftests/measure-frame-time.html
 * fast/harness/perftests/measure-time.html

Which are failing with;
 CONSOLE ERROR: line 66: Uncaught ReferenceError: PerfTestRunner is not
 defined

BUG=524758
==========

to

==========
WebKit LayoutTests needs more resources.

It needs the PerformanceTests directory. This should fix the following 
failures;
 * fast/harness/perftests/perf-runner-compute-statistics.html
 * fast/harness/perftests/runs-per-second-iterations.html
 * fast/harness/perftests/runs-per-second-log.html
 * fast/harness/perftests/measure-frame-time.html
 * fast/harness/perftests/measure-time.html
Which are failing with;
 CONSOLE ERROR: line 66: Uncaught ReferenceError: PerfTestRunner is not
 defined

It needs the extracted devtools resources. This should fix the following
failures;
 * inspector-protocol/heap-profiler/heap-samples-in-snapshot.html       
 * inspector-protocol/heap-profiler/heap-snapshot-with-active-dom-object.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html
Which are failing with;
 TypeError: HeapSnapshotWorker.HeapSnapshotLoader is not a constructor

BUG=52475
==========

[mithro, 2017-02-17 21:07:44]

The CQ bit was checked by tansell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 21:08:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mithro, 2017-02-17 21:12:55]

Description was changed from

==========
WebKit LayoutTests needs more resources.

It needs the PerformanceTests directory. This should fix the following 
failures;
 * fast/harness/perftests/perf-runner-compute-statistics.html
 * fast/harness/perftests/runs-per-second-iterations.html
 * fast/harness/perftests/runs-per-second-log.html
 * fast/harness/perftests/measure-frame-time.html
 * fast/harness/perftests/measure-time.html
Which are failing with;
 CONSOLE ERROR: line 66: Uncaught ReferenceError: PerfTestRunner is not
 defined

It needs the extracted devtools resources. This should fix the following
failures;
 * inspector-protocol/heap-profiler/heap-samples-in-snapshot.html       
 * inspector-protocol/heap-profiler/heap-snapshot-with-active-dom-object.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html
Which are failing with;
 TypeError: HeapSnapshotWorker.HeapSnapshotLoader is not a constructor

BUG=52475
==========

to

==========
WebKit LayoutTests needs more resources.

It needs the PerformanceTests directory. This should fix the following 
failures;
 * fast/harness/perftests/perf-runner-compute-statistics.html
 * fast/harness/perftests/runs-per-second-iterations.html
 * fast/harness/perftests/runs-per-second-log.html
 * fast/harness/perftests/measure-frame-time.html
 * fast/harness/perftests/measure-time.html
Which are failing with;
 CONSOLE ERROR: line 66: Uncaught ReferenceError: PerfTestRunner is not
 defined

It needs the extracted devtools resources (bug https://crbug.com/693723
created for this). This should fix the following failures;
 * inspector-protocol/heap-profiler/heap-samples-in-snapshot.html       
 * inspector-protocol/heap-profiler/heap-snapshot-with-active-dom-object.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html
Which are failing with;
 TypeError: HeapSnapshotWorker.HeapSnapshotLoader is not a constructor

BUG=52475,693723
==========

[mithro, 2017-02-17 21:14:32]

The CQ bit was unchecked by tansell@chromium.org

[mithro, 2017-02-17 21:14:36]

The CQ bit was checked by tansell@chromium.org

[mithro, 2017-02-17 21:14:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2705653002/#ps20001
(title: "WebKit LayoutTests needs more resources.")

[commit-bot: I haz the power, 2017-02-17 21:15:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2017-02-17 21:34:06]

https://codereview.chromium.org/2705653002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2705653002/diff/20001/BUILD.gn#newcode936
BUILD.gn:936:
"//third_party/WebKit/public:blink_devtools_frontend_resources_files",
nit: Sort this, please.

[mithro, 2017-02-17 21:35:43]

https://codereview.chromium.org/2705653002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2705653002/diff/20001/BUILD.gn#newcode936
BUILD.gn:936:
"//third_party/WebKit/public:blink_devtools_frontend_resources_files",
On 2017/02/17 21:34:06, jbudorick wrote:
> nit: Sort this, please.

Why didn't "gn format" do that?

[mithro, 2017-02-17 21:35:49]

The CQ bit was checked by tansell@chromium.org

[mithro, 2017-02-17 21:35:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2705653002/#ps40001
(title: "Fixing sorting.")

[commit-bot: I haz the power, 2017-02-17 21:36:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2017-02-17 21:37:24]

On 2017/02/17 21:35:43, mithro wrote:
> https://codereview.chromium.org/2705653002/diff/20001/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/2705653002/diff/20001/BUILD.gn#newcode936
> BUILD.gn:936:
> "//third_party/WebKit/public:blink_devtools_frontend_resources_files",
> On 2017/02/17 21:34:06, jbudorick wrote:
> > nit: Sort this, please.
> 
> Why didn't "gn format" do that?

hmm, I'm not sure.

[alph, 2017-02-17 22:10:21]

alph@chromium.org changed reviewers:
+ alph@chromium.org, pfeldman@chromium.org

[alph, 2017-02-17 22:10:22]

+pfeldman

[pfeldman, 2017-02-17 22:15:33]

pfeldman@chromium.org changed reviewers:
+ chenwilliam@chromium.org
- alph@chromium.org, pfeldman@chromium.org

[alph, 2017-02-17 22:15:35]

alph@chromium.org changed reviewers:
+ pfeldman@chromium.org
- chenwilliam@chromium.org

[pfeldman, 2017-02-17 22:16:01]

Will, over to you!

[commit-bot: I haz the power, 2017-02-17 23:19:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:19:18]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[qyearsley, 2017-02-17 23:21:01]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 23:23:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 23:39:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:39:51]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[mithro, 2017-02-17 23:41:21]

The CQ bit was checked by tansell@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:42:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 01:46:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:46:41]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[mithro, 2017-02-18 01:47:29]

Description was changed from

==========
WebKit LayoutTests needs more resources.

It needs the PerformanceTests directory. This should fix the following 
failures;
 * fast/harness/perftests/perf-runner-compute-statistics.html
 * fast/harness/perftests/runs-per-second-iterations.html
 * fast/harness/perftests/runs-per-second-log.html
 * fast/harness/perftests/measure-frame-time.html
 * fast/harness/perftests/measure-time.html
Which are failing with;
 CONSOLE ERROR: line 66: Uncaught ReferenceError: PerfTestRunner is not
 defined

It needs the extracted devtools resources (bug https://crbug.com/693723
created for this). This should fix the following failures;
 * inspector-protocol/heap-profiler/heap-samples-in-snapshot.html       
 * inspector-protocol/heap-profiler/heap-snapshot-with-active-dom-object.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html
Which are failing with;
 TypeError: HeapSnapshotWorker.HeapSnapshotLoader is not a constructor

BUG=52475,693723
==========

to

==========
WebKit LayoutTests needs more resources.

It needs the PerformanceTests directory. This should fix the following 
failures;
 * fast/harness/perftests/perf-runner-compute-statistics.html
 * fast/harness/perftests/runs-per-second-iterations.html
 * fast/harness/perftests/runs-per-second-log.html
 * fast/harness/perftests/measure-frame-time.html
 * fast/harness/perftests/measure-time.html
Which are failing with;
 CONSOLE ERROR: line 66: Uncaught ReferenceError: PerfTestRunner is not
 defined

It needs the extracted devtools resources (bug https://crbug.com/693723
created for this). This should fix the following failures;
 * inspector-protocol/heap-profiler/heap-samples-in-snapshot.html       
 * inspector-protocol/heap-profiler/heap-snapshot-with-active-dom-object.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html
Which are failing with;
 TypeError: HeapSnapshotWorker.HeapSnapshotLoader is not a constructor

BUG=52475,693723
NOTRY=true
==========

[mithro, 2017-02-18 01:47:38]

The CQ bit was checked by tansell@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:49:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 03:52:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 03:52:20]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[mithro, 2017-02-18 03:53:08]

The CQ bit was checked by tansell@chromium.org

[commit-bot: I haz the power, 2017-02-18 03:53:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 04:01:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487389988591340,
"parent_rev": "bb3232b44160a665e67c55d9c43b74794c963279", "commit_rev":
"2bf83ac0e39afbe323a7afe1bd89386ebda50034"}

[commit-bot: I haz the power, 2017-02-18 04:14:20]

Description was changed from

==========
WebKit LayoutTests needs more resources.

It needs the PerformanceTests directory. This should fix the following 
failures;
 * fast/harness/perftests/perf-runner-compute-statistics.html
 * fast/harness/perftests/runs-per-second-iterations.html
 * fast/harness/perftests/runs-per-second-log.html
 * fast/harness/perftests/measure-frame-time.html
 * fast/harness/perftests/measure-time.html
Which are failing with;
 CONSOLE ERROR: line 66: Uncaught ReferenceError: PerfTestRunner is not
 defined

It needs the extracted devtools resources (bug https://crbug.com/693723
created for this). This should fix the following failures;
 * inspector-protocol/heap-profiler/heap-samples-in-snapshot.html       
 * inspector-protocol/heap-profiler/heap-snapshot-with-active-dom-object.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html
Which are failing with;
 TypeError: HeapSnapshotWorker.HeapSnapshotLoader is not a constructor

BUG=52475,693723
NOTRY=true
==========

to

==========
WebKit LayoutTests needs more resources.

It needs the PerformanceTests directory. This should fix the following
failures;
 * fast/harness/perftests/perf-runner-compute-statistics.html
 * fast/harness/perftests/runs-per-second-iterations.html
 * fast/harness/perftests/runs-per-second-log.html
 * fast/harness/perftests/measure-frame-time.html
 * fast/harness/perftests/measure-time.html
Which are failing with;
 CONSOLE ERROR: line 66: Uncaught ReferenceError: PerfTestRunner is not
 defined

It needs the extracted devtools resources (bug https://crbug.com/693723
created for this). This should fix the following failures;
 * inspector-protocol/heap-profiler/heap-samples-in-snapshot.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-active-dom-object.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html
Which are failing with;
 TypeError: HeapSnapshotWorker.HeapSnapshotLoader is not a constructor

BUG=52475,693723
NOTRY=true

Review-Url: https://codereview.chromium.org/2705653002
Cr-Commit-Position: refs/heads/master@{#451412}
Committed:
https://chromium.googlesource.com/chromium/src/+/2bf83ac0e39afbe323a7afe1bd89...
==========

[commit-bot: I haz the power, 2017-02-18 04:14:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2bf83ac0e39afbe323a7afe1bd89...

[Dirk Pranke, 2017-02-23 03:00:07]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2017-02-23 03:00:08]

ugh, the performancetests dependency is unfortunate.

lgtm, though.