Cleanup virtual test suites for origin trials

Cleanup virtual test suites for origin trials

Remove the 'stable' virtual suite for origin trials layout tests. This
was redundant, as it had the identical expectations as the 'disabled'
virtual suite.

Rename/change the 'disabled' virtual suite to be based strictly on
runtime flags.

BUG=685788
Review-Url: https://codereview.chromium.org/2705643002
Cr-Commit-Position: refs/heads/master@{#452552}
Committed: https://chromium.googlesource.com/chromium/src/+/0ac7dd29d6b7537444599db5342de36c8f5c6a69

[chasej, 2017-02-17 19:39:41]

The CQ bit was checked by chasej@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 19:40:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 19:45:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 19:45:54]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chasej, 2017-02-17 19:59:16]

The CQ bit was checked by chasej@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 20:00:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 22:36:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 22:36:07]

Dry run: This issue passed the CQ dry run.

[chasej, 2017-02-21 15:10:33]

chasej@chromium.org changed reviewers:
+ iclelland@chromium.org

[chasej, 2017-02-21 15:10:34]

iclelland, please take a look.

[iclelland, 2017-02-22 21:14:15]

On 2017/02/21 15:10:34, chasej wrote:
> iclelland, please take a look.

This looks good; the only other thing I'd ask for is an update to
docs/origin_trials_integration.md, mentioning to feature authors that they need
to add their runtime flag to third_party/WebKit/LayoutTests/VirtualTestSuites.

[chasej, 2017-02-23 16:53:03]

On 2017/02/22 21:14:15, iclelland wrote:
> On 2017/02/21 15:10:34, chasej wrote:
> > iclelland, please take a look.
> 
> This looks good; the only other thing I'd ask for is an update to
> docs/origin_trials_integration.md, mentioning to feature authors that they
need
> to add their runtime flag to third_party/WebKit/LayoutTests/VirtualTestSuites.

I added instructions for layout tests. Although, I'm hoping to remove the need
for
updating the command line in a later CL.

[iclelland, 2017-02-23 16:57:08]

On 2017/02/23 16:53:03, chasej wrote:
> On 2017/02/22 21:14:15, iclelland wrote:
> > On 2017/02/21 15:10:34, chasej wrote:
> > > iclelland, please take a look.
> > 
> > This looks good; the only other thing I'd ask for is an update to
> > docs/origin_trials_integration.md, mentioning to feature authors that they
> need
> > to add their runtime flag to
third_party/WebKit/LayoutTests/VirtualTestSuites.
> 
> I added instructions for layout tests. Although, I'm hoping to remove the need
> for
> updating the command line in a later CL.

LGTM, thanks!

I know we want to change it, but in case it takes longer than expected, I just
want to try to keep the in-repo documentation up-to-date.

[chasej, 2017-02-23 17:05:55]

The CQ bit was checked by chasej@chromium.org

[commit-bot: I haz the power, 2017-02-23 17:06:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 18:16:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487869555027970,
"parent_rev": "29f1aefe09e181a54a437ab6c2845db8d6463e9b", "commit_rev":
"0ac7dd29d6b7537444599db5342de36c8f5c6a69"}

[commit-bot: I haz the power, 2017-02-23 18:17:40]

Description was changed from

==========
Cleanup virtual test suites for origin trials

Remove the 'stable' virtual suite for origin trials layout tests. This
was redundant, as it had the identical expectations as the 'disabled'
virtual suite.

Rename/change the 'disabled' virtual suite to be based strictly on
runtime flags.

BUG=685788
==========

to

==========
Cleanup virtual test suites for origin trials

Remove the 'stable' virtual suite for origin trials layout tests. This
was redundant, as it had the identical expectations as the 'disabled'
virtual suite.

Rename/change the 'disabled' virtual suite to be based strictly on
runtime flags.

BUG=685788

Review-Url: https://codereview.chromium.org/2705643002
Cr-Commit-Position: refs/heads/master@{#452552}
Committed:
https://chromium.googlesource.com/chromium/src/+/0ac7dd29d6b7537444599db5342d...
==========

[commit-bot: I haz the power, 2017-02-23 18:17:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0ac7dd29d6b7537444599db5342d...