chrome/browser/resources/settings/languages_page/languages_page.html - Issue 2705543003: MD-Settings: Adds an a11y label to most toggle buttons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2705543003: MD-Settings: Adds an a11y label to most toggle buttons. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/controls/settings_toggle_button.html ('K') | « chrome/browser/resources/settings/internet_page/network_siminfo.html ('k') | chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/languages_page/languages_page.html

diff --git a/chrome/browser/resources/settings/languages_page/languages_page.html b/chrome/browser/resources/settings/languages_page/languages_page.html

index 33580fbbdaf25c996b7c3ed567ff79e0b16dccfc..078c9a6109bca9c7d29d0970c5ff28d749d9042c 100644

--- a/chrome/browser/resources/settings/languages_page/languages_page.html

+++ b/chrome/browser/resources/settings/languages_page/languages_page.html

@@ -210,7 +210,8 @@

</div>

<paper-toggle-button on-change="onSpellCheckChange_"

disabled="[[!item.language.supportsSpellcheck]]"

- checked="[[item.spellCheckEnabled]]">

+ checked="[[item.spellCheckEnabled]]"

+ aria-label$="[[item.language.displayName]]">

dschuyler 2017/02/22 23:43:33 aria-label$= is used here, while aria-label= is us

Dan Beam 2017/02/23 00:00:38 yes

</paper-toggle-button>

</div>

</template>