chrome/browser/resources/settings/controls/settings_toggle_button.html - Issue 2705543003: MD-Settings: Adds an a11y label to most toggle buttons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/controls/settings_toggle_button.html

Issue 2705543003: MD-Settings: Adds an a11y label to most toggle buttons. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/a11y_page/a11y_page.html ('k') | chrome/browser/resources/settings/date_time_page/date_time_page.html » ('j') | chrome/browser/resources/settings/languages_page/languages_page.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/controls/settings_toggle_button.html

diff --git a/chrome/browser/resources/settings/controls/settings_toggle_button.html b/chrome/browser/resources/settings/controls/settings_toggle_button.html

index a294ae0e7e63f732b6060118f7f0590acb3a25e8..c20a033c7e28bbc0837dac720c0d0b4009da1763 100644

--- a/chrome/browser/resources/settings/controls/settings_toggle_button.html

+++ b/chrome/browser/resources/settings/controls/settings_toggle_button.html

@@ -39,7 +39,7 @@

<div class="flex" on-tap="onLabelWrapperTap_"

actionable$="[[!controlDisabled_(disabled, pref)]]">

- <div class="label">

+ <div id="label" class="label">

[[label]]

</div>

<div class="secondary label">[[subLabel]]</div>

@@ -49,7 +49,7 @@

<cr-policy-pref-indicator pref="[[pref]]"></cr-policy-pref-indicator>

</template>

<paper-toggle-button id="control" checked="{{checked}}"

- on-change="notifyChangedByUserInteraction"

+ on-change="notifyChangedByUserInteraction" aria-labelledby="label"

Dan Beam 2017/02/17 22:06:46 yeah, this is the big one

disabled="[[controlDisabled_(disabled, pref)]]">

</paper-toggle-button>

</div>