Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2705493002: [Merge-57] arc: Logging ARC data removal reasons (Closed)

Created:
3 years, 10 months ago by Luis Héctor Chávez
Modified:
3 years, 10 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge-57] arc: Logging ARC data removal reasons There have been cases where the ARC user data has been requested to be removed without having a paper trail about the reason why it happened. This change should provide the reason in the logs so feedback reports at least can tell what happened. BUG=692830 TEST=cq Review-Url: https://codereview.chromium.org/2678273005 Cr-Commit-Position: refs/heads/master@{#449047} (cherry picked from commit 2512542164d696c21c6a62a0f103e1af9c37ca45) R=yusukes@chromium.org Review-Url: https://codereview.chromium.org/2705493002 . Cr-Commit-Position: refs/branch-heads/2987@{#562} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/5fef0127c7d48ef621e3ded6568eabb473ad9d54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -20 lines) Patch
M chrome/browser/chromeos/arc/arc_optin_uma.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_optin_uma.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_session_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_session_manager.cc View 8 chunks +29 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/arc/enterprise/arc_enterprise_reporting_service.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Luis Héctor Chávez
PTAL at this cherry-pick for 57.
3 years, 10 months ago (2017-02-16 21:50:29 UTC) #3
Yusuke Sato
On 2017/02/16 21:50:29, Luis Héctor Chávez wrote: > PTAL at this cherry-pick for 57. Is ...
3 years, 10 months ago (2017-02-16 21:52:45 UTC) #4
Luis Héctor Chávez
On 2017/02/16 21:52:45, Yusuke Sato wrote: > On 2017/02/16 21:50:29, Luis Héctor Chávez wrote: > ...
3 years, 10 months ago (2017-02-16 21:53:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705493002/1
3 years, 10 months ago (2017-02-16 21:55:30 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-16 21:55:33 UTC) #9
Luis Héctor Chávez
3 years, 10 months ago (2017-02-16 21:57:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5fef0127c7d48ef621e3ded6568eabb473ad9d54 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698