Last_n: disable on Svelte devices.

Last_n: disable on Svelte devices.

This CL disables last_n on Svelte devices (less than 512 MB of RAM) as
suggested during discussions. It also adds a test that checks that it
actually does that but still allows user triggered snapshots.

BUG=690753
Review-Url: https://codereview.chromium.org/2705453003
Cr-Commit-Position: refs/heads/master@{#451219}
Committed: https://chromium.googlesource.com/chromium/src/+/ec269885f32e22ded6c3d0531038a18782e5c438

[carlosk, 2017-02-16 20:37:50]

The CQ bit was checked by carlosk@chromium.org to run a CQ dry run

[carlosk, 2017-02-16 20:39:04]

carlosk@chromium.org changed reviewers:
+ dimich@chromium.org

[carlosk, 2017-02-16 20:39:04]

dimich@ PTAL.

[commit-bot: I haz the power, 2017-02-16 20:39:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dmitry Titov, 2017-02-16 20:58:41]

https://codereview.chromium.org/2705453003/diff/1/chrome/browser/android/offl...
File chrome/browser/android/offline_pages/recent_tab_helper.h (right):

https://codereview.chromium.org/2705453003/diff/1/chrome/browser/android/offl...
chrome/browser/android/offline_pages/recent_tab_helper.h:90:
FRIEND_TEST_ALL_PREFIXES(RecentTabHelperTest, LastNDisabledOnSvelte);
Could we add a getter on Delegate to return whether it's a low end device? We
already use Delegate here for dependency injection during testing, so would be
nice to only have one method.

[commit-bot: I haz the power, 2017-02-16 21:31:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 21:31:10]

Dry run: This issue passed the CQ dry run.

[carlosk, 2017-02-16 21:43:06]

The CQ bit was checked by carlosk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 21:44:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[carlosk, 2017-02-16 21:48:17]

Thanks. I didn't realize that thing about the delegate before. Nice! :)

https://codereview.chromium.org/2705453003/diff/1/chrome/browser/android/offl...
File chrome/browser/android/offline_pages/recent_tab_helper.h (right):

https://codereview.chromium.org/2705453003/diff/1/chrome/browser/android/offl...
chrome/browser/android/offline_pages/recent_tab_helper.h:90:
FRIEND_TEST_ALL_PREFIXES(RecentTabHelperTest, LastNDisabledOnSvelte);
On 2017/02/16 20:58:41, Dmitry Titov wrote:
> Could we add a getter on Delegate to return whether it's a low end device? We
> already use Delegate here for dependency injection during testing, so would be
> nice to only have one method.

Done. I also added a getter for the initial test delegate created by
RecentTabHelperTest::SetUp as it was unnecessary to create a new one in 3 test
cases (including this new one).

[commit-bot: I haz the power, 2017-02-16 23:05:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 23:05:59]

Dry run: This issue passed the CQ dry run.

[Dmitry Titov, 2017-02-17 02:14:37]

lgtm

[carlosk, 2017-02-17 02:23:45]

The CQ bit was checked by carlosk@chromium.org

[commit-bot: I haz the power, 2017-02-17 02:25:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 04:47:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487298225407740,
"parent_rev": "4348a58ce41a92ecb5cd1acf6e86269130e61709", "commit_rev":
"ec269885f32e22ded6c3d0531038a18782e5c438"}

[commit-bot: I haz the power, 2017-02-17 04:48:20]

Description was changed from

==========
Last_n: disable on Svelte devices.

This CL disables last_n on Svelte devices (less than 512 MB of RAM) as
suggested during discussions. It also adds a test that checks that it
actually does that but still allows user triggered snapshots.

BUG=690753
==========

to

==========
Last_n: disable on Svelte devices.

This CL disables last_n on Svelte devices (less than 512 MB of RAM) as
suggested during discussions. It also adds a test that checks that it
actually does that but still allows user triggered snapshots.

BUG=690753

Review-Url: https://codereview.chromium.org/2705453003
Cr-Commit-Position: refs/heads/master@{#451219}
Committed:
https://chromium.googlesource.com/chromium/src/+/ec269885f32e22ded6c3d0531038...
==========

[commit-bot: I haz the power, 2017-02-17 04:48:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ec269885f32e22ded6c3d0531038...