Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2705453002: Force compositing/overflow/composited-sticky-element to be composited (Closed)

Created:
3 years, 10 months ago by smcgruer
Modified:
3 years, 10 months ago
Reviewers:
flackr
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force compositing/overflow/composited-sticky-element to be composited This test was relying on opaque backgrounds to cause the elements to be promoted, which is not correct. Since the condition under test is just to have a composited sticky element in a composited scroller, mark them both will-change: transform instead. BUG=693158 Review-Url: https://codereview.chromium.org/2705453002 Cr-Commit-Position: refs/heads/master@{#451089} Committed: https://chromium.googlesource.com/chromium/src/+/43624d14130e30730e344a897c2f62f89ff4d33d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Actually composite... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element.html View 1 1 chunk +7 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element-expected.html View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
smcgruer
3 years, 10 months ago (2017-02-16 19:14:08 UTC) #3
flackr
https://codereview.chromium.org/2705453002/diff/1/third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element.html File third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element.html (right): https://codereview.chromium.org/2705453002/diff/1/third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element.html#newcode7 third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element.html:7: .composite { did you mean .composited?
3 years, 10 months ago (2017-02-16 19:21:37 UTC) #5
smcgruer
https://codereview.chromium.org/2705453002/diff/1/third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element.html File third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element.html (right): https://codereview.chromium.org/2705453002/diff/1/third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element.html#newcode7 third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element.html:7: .composite { On 2017/02/16 19:21:37, flackr wrote: > did ...
3 years, 10 months ago (2017-02-16 19:24:17 UTC) #7
smcgruer
https://codereview.chromium.org/2705453002/diff/1/third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element.html File third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element.html (right): https://codereview.chromium.org/2705453002/diff/1/third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element.html#newcode7 third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element.html:7: .composite { On 2017/02/16 19:21:37, flackr wrote: > did ...
3 years, 10 months ago (2017-02-16 19:24:17 UTC) #8
flackr
lgtm
3 years, 10 months ago (2017-02-16 19:27:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705453002/20001
3 years, 10 months ago (2017-02-16 19:28:50 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 20:37:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/43624d14130e30730e344a897c2f...

Powered by Google App Engine
This is Rietveld 408576698