Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Unified Diff: dm/DMRecordTask.h

Issue 270543004: DM: Add --skps. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fix and verbatim Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DM.cpp ('k') | dm/DMRecordTask.cpp » ('j') | dm/DMRecordTask.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMRecordTask.h
diff --git a/dm/DMRecordTask.h b/dm/DMRecordTask.h
index 94ac412e4246f049de4eb25ecc694c5aac6381da..68134dc865411d867bf7b51a05b2644b68471bcc 100644
--- a/dm/DMRecordTask.h
+++ b/dm/DMRecordTask.h
@@ -3,11 +3,12 @@
#include "DMTask.h"
#include "SkBitmap.h"
+#include "SkPicture.h"
#include "SkString.h"
#include "SkTemplates.h"
#include "gm.h"
-// Records a GM through an SkRecord, draws it, and compares against the reference bitmap.
+// Records a GM or SKP through an SkRecord, draws it, and compares against the reference bitmap.
namespace DM {
@@ -15,6 +16,7 @@ class RecordTask : public CpuTask {
public:
RecordTask(const Task& parent, skiagm::GM*, SkBitmap reference, bool optimize);
reed1 2014/05/14 12:40:11 nit: why isn't this parameter const SkBitmap& ?
mtklein 2014/05/14 17:47:18 It could be, but we've got to make the copy either
+ RecordTask(const Task& parent, SkPicture*, SkBitmap reference, bool optimize);
virtual void draw() SK_OVERRIDE;
virtual bool shouldSkip() const SK_OVERRIDE;
@@ -22,6 +24,7 @@ public:
private:
const SkString fName;
+ SkAutoTUnref<SkPicture> fPicture;
SkAutoTDelete<skiagm::GM> fGM;
const SkBitmap fReference;
bool fOptimize;
« no previous file with comments | « dm/DM.cpp ('k') | dm/DMRecordTask.cpp » ('j') | dm/DMRecordTask.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698