Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: dm/DMRecordTask.cpp

Issue 270543004: DM: Add --skps. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fix and verbatim Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dm/DMRecordTask.cpp
diff --git a/dm/DMRecordTask.cpp b/dm/DMRecordTask.cpp
index 531fe57f9476f489b1bd6157456b6eda28acd156..b660e00c2dd9fa352aae20e9570bbd15441b19cb 100644
--- a/dm/DMRecordTask.cpp
+++ b/dm/DMRecordTask.cpp
@@ -19,13 +19,27 @@ RecordTask::RecordTask(const Task& parent, skiagm::GM* gm, SkBitmap reference, b
, fOptimize(optimize)
{}
+RecordTask::RecordTask(const Task& parent, SkPicture* pic, SkBitmap reference, bool optimize)
reed1 2014/05/14 12:40:11 nit: the call-sites are slightly harder to underst
mtklein 2014/05/14 17:47:18 Done, for all the existing tasks too.
+ : CpuTask(parent)
+ , fName(UnderJoin(parent.name().c_str(), optimize ? "skr" : "skr-noopt"))
+ , fPicture(SkRef(pic))
+ , fReference(reference)
+ , fOptimize(optimize)
+ {}
+
void RecordTask::draw() {
- // Record the GM into an SkRecord.
+ // Record into an SkRecord.
SkRecord record;
SkRecorder recorder(SkRecorder::kWriteOnly_Mode, &record,
fReference.width(), fReference.height());
- recorder.concat(fGM->getInitialTransform());
- fGM->draw(&recorder);
+
+ if (fGM.get()) {
+ recorder.concat(fGM->getInitialTransform());
+ fGM->draw(&recorder);
+ } else {
+ fPicture->draw(&recorder);
+ }
+
if (fOptimize) {
SkRecordOptimize(&record);
@@ -33,7 +47,11 @@ void RecordTask::draw() {
// Draw the SkRecord back into a bitmap.
SkBitmap bitmap;
- SetupBitmap(fReference.colorType(), fGM.get(), &bitmap);
+ if (fGM.get()) {
+ SetupBitmap(fReference.colorType(), fGM.get(), &bitmap);
+ } else {
+ SetupBitmap(fReference.colorType(), *fPicture, &bitmap);
+ }
SkCanvas target(bitmap);
SkRecordDraw(record, &target);

Powered by Google App Engine
This is Rietveld 408576698