Chromium Code Reviews| Index: dm/DMRecordTask.h |
| diff --git a/dm/DMRecordTask.h b/dm/DMRecordTask.h |
| index 94ac412e4246f049de4eb25ecc694c5aac6381da..68134dc865411d867bf7b51a05b2644b68471bcc 100644 |
| --- a/dm/DMRecordTask.h |
| +++ b/dm/DMRecordTask.h |
| @@ -3,11 +3,12 @@ |
| #include "DMTask.h" |
| #include "SkBitmap.h" |
| +#include "SkPicture.h" |
| #include "SkString.h" |
| #include "SkTemplates.h" |
| #include "gm.h" |
| -// Records a GM through an SkRecord, draws it, and compares against the reference bitmap. |
| +// Records a GM or SKP through an SkRecord, draws it, and compares against the reference bitmap. |
| namespace DM { |
| @@ -15,6 +16,7 @@ class RecordTask : public CpuTask { |
| public: |
| RecordTask(const Task& parent, skiagm::GM*, SkBitmap reference, bool optimize); |
|
reed1
2014/05/14 12:40:11
nit: why isn't this parameter const SkBitmap& ?
mtklein
2014/05/14 17:47:18
It could be, but we've got to make the copy either
|
| + RecordTask(const Task& parent, SkPicture*, SkBitmap reference, bool optimize); |
| virtual void draw() SK_OVERRIDE; |
| virtual bool shouldSkip() const SK_OVERRIDE; |
| @@ -22,6 +24,7 @@ public: |
| private: |
| const SkString fName; |
| + SkAutoTUnref<SkPicture> fPicture; |
| SkAutoTDelete<skiagm::GM> fGM; |
| const SkBitmap fReference; |
| bool fOptimize; |