Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2705423003:
[build] Fix gyp files for building inspector (Closed)
Description[build] Fix gyp files for building inspector
This patch fixes compilation of V8 with inspector on Windows as well as
cross-compilation of the V8 inspector.
BUG=
Refs: https://github.com/nodejs/node/pull/10992
Review-Url: https://codereview.chromium.org/2705423003
Cr-Commit-Position: refs/heads/master@{#43533}
Committed: https://chromium.googlesource.com/v8/v8/+/c5c570f0c0dd638b59406c0d1eae0bca96fd6f0c
Patch Set 1 #
Messages
Total messages: 24 (13 generated)
Description was changed from ========== [build] Fix gyp files for building inspector This patch fixes compilation of V8 with inspector on Windows as well as cross-compilation of the V8 inspector. BUG= Refs: https://github.com/nodejs/node/pull/10992 ========== to ========== [build] Fix gyp files for building inspector This patch fixes compilation of V8 with inspector on Windows as well as cross-compilation of the V8 inspector. BUG= Refs: https://github.com/nodejs/node/pull/10992 ==========
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks! LGTM
The CQ bit was checked by franzih@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/35423)
mic.besace@gmail.com changed reviewers: + dgozman@chromium.org, jochen@chromium.org, yangguo@chromium.org
Looks like it needs a review from an inspector owner?
lgtm - stamp
The CQ bit was checked by franzih@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/35808)
On 2017/03/02 09:34:30, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > v8_presubmit on master.tryserver.v8 (JOB_FAILED, > http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/35808) lgtm.
The CQ bit was checked by franzih@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1488447674786970, "parent_rev":
"4cbac8ffb2ea89b5e44fc7e9fd3f4baecdea023d", "commit_rev":
"c5c570f0c0dd638b59406c0d1eae0bca96fd6f0c"}
Message was sent while issue was closed.
Description was changed from ========== [build] Fix gyp files for building inspector This patch fixes compilation of V8 with inspector on Windows as well as cross-compilation of the V8 inspector. BUG= Refs: https://github.com/nodejs/node/pull/10992 ========== to ========== [build] Fix gyp files for building inspector This patch fixes compilation of V8 with inspector on Windows as well as cross-compilation of the V8 inspector. BUG= Refs: https://github.com/nodejs/node/pull/10992 Review-Url: https://codereview.chromium.org/2705423003 Cr-Commit-Position: refs/heads/master@{#43533} Committed: https://chromium.googlesource.com/v8/v8/+/c5c570f0c0dd638b59406c0d1eae0bca96f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/c5c570f0c0dd638b59406c0d1eae0bca96f... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
