Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2705423002: Remove several unnecessary selection-related layout updates (Closed)

Created:
3 years, 10 months ago by Xiaocheng
Modified:
3 years, 10 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove several unnecessary selection-related layout updates Now that setting frame selection no longer requires clean layout, updating layout before modifying frame selection becomes redundant, unless for other reasons. This patch removes such redundant calls. BUG=590369 Review-Url: https://codereview.chromium.org/2705423002 Cr-Commit-Position: refs/heads/master@{#452076} Committed: https://chromium.googlesource.com/chromium/src/+/4f6f34fa8f9cd4e53fa7f02d56680c49cf100979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -26 lines) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 3 chunks +1 line, -17 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Xiaocheng
PTAL.
3 years, 10 months ago (2017-02-22 05:46:03 UTC) #5
yosin_UTC9
lgtm Thanks for fixing them!
3 years, 10 months ago (2017-02-22 06:21:30 UTC) #6
tkent
lgtm
3 years, 10 months ago (2017-02-22 06:25:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705423002/1
3 years, 10 months ago (2017-02-22 16:10:29 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 16:15:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f6f34fa8f9cd4e53fa7f02d5668...

Powered by Google App Engine
This is Rietveld 408576698