Move oom.h into partition_allocator.

Move oom.h into partition_allocator.

This helps make partition_alloc more self-contained.

BUG=695274
Review-Url: https://codereview.chromium.org/2705413003
Cr-Commit-Position: refs/heads/master@{#452613}
Committed: https://chromium.googlesource.com/chromium/src/+/19c820347cfb8ac49abc175cc7ca0d9c65cd445f

[palmer, 2017-02-23 01:26:25]

palmer@chromium.org changed reviewers:
+ haraken@chromium.org, primiano@chromium.org

[palmer, 2017-02-23 01:26:30]

The CQ bit was checked by palmer@chromium.org to run a CQ dry run

[palmer, 2017-02-23 01:26:52]

Should be a simple, small one for you. Thanks!

primiano: base/allocator/OWNERS
haraken: The rest

[commit-bot: I haz the power, 2017-02-23 01:27:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[palmer, 2017-02-23 01:27:50]

The CQ bit was unchecked by palmer@chromium.org

[palmer, 2017-02-23 01:28:21]

The CQ bit was checked by palmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 01:28:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 01:33:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 01:33:41]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[palmer, 2017-02-23 01:50:38]

palmer@chromium.org changed reviewers:
+ dcheng@chromium.org

[palmer, 2017-02-23 01:50:56]

dcheng: Adding you for base/BUILD.gn.

[palmer, 2017-02-23 01:51:01]

The CQ bit was checked by palmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 01:51:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-23 02:47:43]

LGTM

[dcheng, 2017-02-23 02:50:12]

LGTM

https://codereview.chromium.org/2705413003/diff/40001/base/allocator/partitio...
File base/allocator/partition_allocator/oom.h (right):

https://codereview.chromium.org/2705413003/diff/40001/base/allocator/partitio...
base/allocator/partition_allocator/oom.h:5: #ifndef BASE_ALLOCATOR_OOM_H
Nit: fix header guards

[commit-bot: I haz the power, 2017-02-23 04:10:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 04:10:48]

Dry run: This issue passed the CQ dry run.

[Primiano Tucci (use gerrit), 2017-02-23 14:27:51]

LGTM 

I think that very subtly
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
also depend on that OOM_CRASH in reportOOMErrorInMainThread:
(Not a reason for not move oom.h)

+wfh

[palmer, 2017-02-23 18:12:51]

> I think that very subtly
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
> also depend on that OOM_CRASH in reportOOMErrorInMainThread:
> (Not a reason for not move oom.h)

Looks like V8Initializer.cpp gets access to OOM_CRASH via wtf/Assertions.h
(although without including it explicitly). I'll add it explicitly.

[palmer, 2017-02-23 18:17:01]

The CQ bit was checked by palmer@chromium.org

[palmer, 2017-02-23 18:17:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, primiano@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2705413003/#ps60001
(title: "IWYU: Assertions.h.")

[commit-bot: I haz the power, 2017-02-23 18:17:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Will Harris, 2017-02-23 18:40:58]

As long as it still ends up calling OOM_CRASH I'm happy with this lgtm

[commit-bot: I haz the power, 2017-02-23 20:42:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487873821609990,
"parent_rev": "ee7e5a6c29a64de238978a82bb95a449e2de9a95", "commit_rev":
"19c820347cfb8ac49abc175cc7ca0d9c65cd445f"}

[commit-bot: I haz the power, 2017-02-23 20:43:25]

Description was changed from

==========
Move oom.h into partition_allocator.

This helps make partition_alloc more self-contained.

BUG=695274
==========

to

==========
Move oom.h into partition_allocator.

This helps make partition_alloc more self-contained.

BUG=695274

Review-Url: https://codereview.chromium.org/2705413003
Cr-Commit-Position: refs/heads/master@{#452613}
Committed:
https://chromium.googlesource.com/chromium/src/+/19c820347cfb8ac49abc175cc7ca...
==========

[commit-bot: I haz the power, 2017-02-23 20:43:26]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/19c820347cfb8ac49abc175cc7ca...