PlzNavigate: Fix the fast/loader/crash-replacing-location-before-load.html layout test.

PlzNavigate: Fix the fast/loader/crash-replacing-location-before-load.html layout test.

This test creates an iframe and then initiates an anchor navigation to the frame. This eventually
goes through the location change code path which schedules a navigation to the anchor url.
With PlzNavigate the anchor navigation is sent to the browser and when the navigation commits
the FrameLoader::loadInSameDocument() function as the url being navigated to is the same as the main
frame url with the difference being the anchor tag.

We currently don't clear the member m_isNavigationHandledByClient in FrameLoader in this code path.
As a result we never mark the navigation as complete when the stack unwinds and hence the test ends up
waiting indefinitely.

Fix is to call FrameLoader::clearNavigationHandledByClient() in the loadInSameDocument() function which
ensures that the navigation is marked as complete correctly.

BUG=695435
Review-Url: https://codereview.chromium.org/2705373006
Cr-Commit-Position: refs/heads/master@{#452978}
Committed: https://chromium.googlesource.com/chromium/src/+/4efc08b53165c7cca522a5d0fcbd5639281f4906

[ananta, 2017-02-23 16:42:38]

ananta@chromium.org changed reviewers:
+ japhet@chromium.org

[ananta, 2017-02-23 16:42:52]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 16:43:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 18:29:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 18:29:34]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2017-02-24 21:01:21]

lgtm

[ananta, 2017-02-24 21:08:57]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-02-24 21:10:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 23:01:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487970537516540, "parent_rev":
"ac2d30797f91fe7927a0b632c418ec6ef616be4a", "commit_rev":
"4efc08b53165c7cca522a5d0fcbd5639281f4906"}

[commit-bot: I haz the power, 2017-02-24 23:03:54]

Description was changed from

==========
PlzNavigate: Fix the fast/loader/crash-replacing-location-before-load.html
layout test.

This test creates an iframe and then initiates an anchor navigation to the
frame. This eventually
goes through the location change code path which schedules a navigation to the
anchor url.
With PlzNavigate the anchor navigation is sent to the browser and when the
navigation commits
the FrameLoader::loadInSameDocument() function as the url being navigated to is
the same as the main
frame url with the difference being the anchor tag.

We currently don't clear the member m_isNavigationHandledByClient in FrameLoader
in this code path.
As a result we never mark the navigation as complete when the stack unwinds and
hence the test ends up
waiting indefinitely.

Fix is to call FrameLoader::clearNavigationHandledByClient() in the
loadInSameDocument() function which
ensures that the navigation is marked as complete correctly.

BUG=695435
==========

to

==========
PlzNavigate: Fix the fast/loader/crash-replacing-location-before-load.html
layout test.

This test creates an iframe and then initiates an anchor navigation to the
frame. This eventually
goes through the location change code path which schedules a navigation to the
anchor url.
With PlzNavigate the anchor navigation is sent to the browser and when the
navigation commits
the FrameLoader::loadInSameDocument() function as the url being navigated to is
the same as the main
frame url with the difference being the anchor tag.

We currently don't clear the member m_isNavigationHandledByClient in FrameLoader
in this code path.
As a result we never mark the navigation as complete when the stack unwinds and
hence the test ends up
waiting indefinitely.

Fix is to call FrameLoader::clearNavigationHandledByClient() in the
loadInSameDocument() function which
ensures that the navigation is marked as complete correctly.

BUG=695435

Review-Url: https://codereview.chromium.org/2705373006
Cr-Commit-Position: refs/heads/master@{#452978}
Committed:
https://chromium.googlesource.com/chromium/src/+/4efc08b53165c7cca522a5d0fcbd...
==========

[commit-bot: I haz the power, 2017-02-24 23:03:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4efc08b53165c7cca522a5d0fcbd...