Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2705373004: [Remote suggestions] Add a remote suggestions flag to choose the source (Closed)

Created:
3 years, 10 months ago by jkrcal
Modified:
3 years, 9 months ago
CC:
chromium-reviews, srahim+watch_chromium.org, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remote suggestions] Add a remote suggestions flag to choose the source This CL removes an obsolete feature "NTPSnippets" and adds a flag into chrome://flags for the remote suggestions feature that allows to specify the source for remote suggestions (the flag was previously there for the obsolete feature but it had no effect). BUG=690453 Review-Url: https://codereview.chromium.org/2705373004 Cr-Commit-Position: refs/heads/master@{#454298} Committed: https://chromium.googlesource.com/chromium/src/+/8f8a5670dffaf0a95d278428ae489a54b7d364bf

Patch Set 1 #

Total comments: 6

Patch Set 2 : Marc's comments #

Patch Set 3 : Rebase #

Patch Set 4 : Add new flags to histograms.xml #

Total comments: 2

Patch Set 5 : Add the other flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -32 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 chunks +18 lines, -18 lines 0 comments Download
M components/ntp_snippets/features.h View 2 chunks +1 line, -5 lines 0 comments Download
M components/ntp_snippets/features.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (13 generated)
jkrcal
Marc, could you PTAL?
3 years, 10 months ago (2017-02-22 12:38:22 UTC) #2
Marc Treib
LGTM with nits https://codereview.chromium.org/2705373004/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2705373004/diff/1/chrome/app/generated_resources.grd#newcode14368 chrome/app/generated_resources.grd:14368: + Furthermore, it allows to override ...
3 years, 10 months ago (2017-02-22 12:45:56 UTC) #3
jkrcal
Thanks! https://codereview.chromium.org/2705373004/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2705373004/diff/1/chrome/app/generated_resources.grd#newcode14368 chrome/app/generated_resources.grd:14368: + Furthermore, it allows to override the source ...
3 years, 10 months ago (2017-02-22 13:32:15 UTC) #4
Marc Treib
Still LGTM, thanks!
3 years, 10 months ago (2017-02-22 13:40:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705373004/40001
3 years, 9 months ago (2017-03-02 09:04:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/129618)
3 years, 9 months ago (2017-03-02 10:28:44 UTC) #10
jkrcal
Ilya, could you PTAL at histograms.xml? https://codereview.chromium.org/2705373004/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2705373004/diff/60001/tools/metrics/histograms/histograms.xml#newcode97986 tools/metrics/histograms/histograms.xml:97986: + <int value="-1882330924" ...
3 years, 9 months ago (2017-03-02 13:29:43 UTC) #14
Ilya Sherman
LGTM, thanks. https://codereview.chromium.org/2705373004/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2705373004/diff/60001/tools/metrics/histograms/histograms.xml#newcode97986 tools/metrics/histograms/histograms.xml:97986: + <int value="-1882330924" label="NTPArticleSuggestions:enabled"/> On 2017/03/02 13:29:43, ...
3 years, 9 months ago (2017-03-02 17:36:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705373004/40002
3 years, 9 months ago (2017-03-02 17:39:36 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 17:45:05 UTC) #23
Message was sent while issue was closed.
Committed patchset #5 (id:40002) as
https://chromium.googlesource.com/chromium/src/+/8f8a5670dffaf0a95d278428ae48...

Powered by Google App Engine
This is Rietveld 408576698