third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp - Issue 2705373002: Remove unnecessary layout updates from InsertInto/DeleteFromTextNodeCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

Issue 2705373002: Remove unnecessary layout updates from InsertInto/DeleteFromTextNodeCommand (Closed)

Patch Set: Add layout updates for clients requiring that explicitly Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

index e1dc8e1f2a8d483f4a13d31518a47d9c6a3e743f..3559d1fc68ae305d7f14a29d7a97bd11df270328 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

@@ -209,6 +209,11 @@ void InsertTextCommand::doApply(EditingState* editingState) {

Position::inParentBeforeNode(*startPosition.computeContainerNode()));

deleteInsignificantText(startPosition,

mostForwardCaretPosition(startPosition));

+ // TODO(editing-dev): Use of updateStyleAndLayoutIgnorePendingStylesheets()

+ // needs to be audited. See http://crbug.com/590369 for more details.

+ document().updateStyleAndLayoutIgnorePendingStylesheets();

if (!startPosition.isConnected())

startPosition = positionBeforeStartNode;

if (!isVisuallyEquivalentCandidate(startPosition))