Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2705343003: Revert of [Android NTP] Allow overlapping snap scroll regions. (Closed)

Created:
3 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 10 months ago
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android NTP] Allow overlapping snap scroll regions. (patchset #3 id:40001 of https://codereview.chromium.org/2708653002/ ) Reason for revert: NewTabPageRecyclerViewTest#testSnapScrollCondensedLayout failing on tablets BUG=694851 Original issue's description: > [Android NTP] Allow overlapping snap scroll regions. > > Previously the code assumed that snap scroll regions would never overlap. > That assumption became false with the condensed NTP layout, with the result that > only the first snap would be applied and the NTP would come to rest in a > position it should have scrolled out of. > > We now apply all snaps in order and have an assertion that the desired position > does not change after one pass. > > BUG=693095 > > Review-Url: https://codereview.chromium.org/2708653002 > Cr-Commit-Position: refs/heads/master@{#451767} > Committed: https://chromium.googlesource.com/chromium/src/+/6617e48c6e0733436a8fc430a17399038975926e TBR=mvanouwerkerk@chromium.org,peconn@chromium.org,bauerb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=693095 Review-Url: https://codereview.chromium.org/2705343003 Cr-Commit-Position: refs/heads/master@{#451861} Committed: https://chromium.googlesource.com/chromium/src/+/8a0be9febc6a33b487eaade15f7ec08cdd5e6b0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -139 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java View 2 chunks +52 lines, -71 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java View 8 chunks +5 lines, -66 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
aelias_OOO_until_Jul13
Created Revert of [Android NTP] Allow overlapping snap scroll regions.
3 years, 10 months ago (2017-02-22 00:59:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705343003/1
3 years, 10 months ago (2017-02-22 01:01:00 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 01:06:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8a0be9febc6a33b487eaade15f7e...

Powered by Google App Engine
This is Rietveld 408576698