Chromium Code Reviews
DescriptionRevert of [Android NTP] Allow overlapping snap scroll regions. (patchset #3 id:40001 of https://codereview.chromium.org/2708653002/ )
Reason for revert:
NewTabPageRecyclerViewTest#testSnapScrollCondensedLayout failing on tablets
BUG=694851
Original issue's description:
> [Android NTP] Allow overlapping snap scroll regions.
>
> Previously the code assumed that snap scroll regions would never overlap.
> That assumption became false with the condensed NTP layout, with the result that
> only the first snap would be applied and the NTP would come to rest in a
> position it should have scrolled out of.
>
> We now apply all snaps in order and have an assertion that the desired position
> does not change after one pass.
>
> BUG=693095
>
> Review-Url: https://codereview.chromium.org/2708653002
> Cr-Commit-Position: refs/heads/master@{#451767}
> Committed: https://chromium.googlesource.com/chromium/src/+/6617e48c6e0733436a8fc430a17399038975926e
TBR=mvanouwerkerk@chromium.org,peconn@chromium.org,bauerb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=693095
Review-Url: https://codereview.chromium.org/2705343003
Cr-Commit-Position: refs/heads/master@{#451861}
Committed: https://chromium.googlesource.com/chromium/src/+/8a0be9febc6a33b487eaade15f7ec08cdd5e6b0d
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||||||||||||||||||||