Last_n: Do not save a snapshot of a closing tab.

Last_n: Do not save a snapshot of a closing tab.

Listening to the tab being hidden as a signal to save last_n offline
snapshots of pages also caused them to be saved for Android tabs that
are being closed. For this platform, when a tab is closed it is
initially hidden for a few seconds as a grace period for the user to
undo the closure.

This change monitors tab-will-close signals in Java and dispatches them
to the last_n native code so that we can register what's going on and
properly ignore the tab hidden event. A test was also added to test this
functionality.

BUG=685791
Review-Url: https://codereview.chromium.org/2705323006
Cr-Commit-Position: refs/heads/master@{#453712}
Committed: https://chromium.googlesource.com/chromium/src/+/f1d756b8310d09fcd4a3e7ab751c4e184c84d5b5

[carlosk, 2017-02-24 00:25:03]

The CQ bit was checked by carlosk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 00:25:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[carlosk, 2017-02-24 00:36:43]

carlosk@chromium.org changed reviewers:
+ dimich@chromium.org

[carlosk, 2017-02-24 00:36:44]

dimich@: PTAL.

Note that this one depends on https://crrev.com/2706343007.

[Dmitry Titov, 2017-02-24 01:49:38]

lgtm with a nit:

https://codereview.chromium.org/2705323006/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/recent_tab_helper.h (right):

https://codereview.chromium.org/2705323006/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/recent_tab_helper.h:154: bool
tab_is_closing = false;
Nit: add "_" at the end of the name.

[carlosk, 2017-02-24 02:06:35]

Thanks.

https://codereview.chromium.org/2705323006/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/recent_tab_helper.h (right):

https://codereview.chromium.org/2705323006/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/recent_tab_helper.h:154: bool
tab_is_closing = false;
On 2017/02/24 01:49:38, Dmitry Titov wrote:
> Nit: add "_" at the end of the name.

Done.

[carlosk, 2017-02-25 01:19:21]

The CQ bit was checked by carlosk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 01:19:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 02:25:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 02:25:51]

Dry run: This issue passed the CQ dry run.

[carlosk, 2017-02-28 21:12:13]

The CQ bit was checked by carlosk@chromium.org

[carlosk, 2017-02-28 21:12:13]

The patchset sent to the CQ was uploaded after l-g-t-m from dimich@chromium.org
Link to the patchset: https://codereview.chromium.org/2705323006/#ps80001
(title: "Rebase after base change landed.")

[commit-bot: I haz the power, 2017-02-28 21:13:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 21:53:10]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488316333541700,
"parent_rev": "e9fb8919aac49896891b5e247483276439e5d5dd", "commit_rev":
"f1d756b8310d09fcd4a3e7ab751c4e184c84d5b5"}

[commit-bot: I haz the power, 2017-02-28 21:54:06]

Description was changed from

==========
Last_n: Do not save a snapshot of a closing tab.

Listening to the tab being hidden as a signal to save last_n offline
snapshots of pages also caused them to be saved for Android tabs that
are being closed. For this platform, when a tab is closed it is
initially hidden for a few seconds as a grace period for the user to
undo the closure.

This change monitors tab-will-close signals in Java and dispatches them
to the last_n native code so that we can register what's going on and
properly ignore the tab hidden event. A test was also added to test this
functionality.

BUG=685791
==========

to

==========
Last_n: Do not save a snapshot of a closing tab.

Listening to the tab being hidden as a signal to save last_n offline
snapshots of pages also caused them to be saved for Android tabs that
are being closed. For this platform, when a tab is closed it is
initially hidden for a few seconds as a grace period for the user to
undo the closure.

This change monitors tab-will-close signals in Java and dispatches them
to the last_n native code so that we can register what's going on and
properly ignore the tab hidden event. A test was also added to test this
functionality.

BUG=685791

Review-Url: https://codereview.chromium.org/2705323006
Cr-Commit-Position: refs/heads/master@{#453712}
Committed:
https://chromium.googlesource.com/chromium/src/+/f1d756b8310d09fcd4a3e7ab751c...
==========

[commit-bot: I haz the power, 2017-02-28 21:54:12]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f1d756b8310d09fcd4a3e7ab751c...