Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2705323002: Fix incorrect behavior in checking for TCP FastOpen platform support. (Closed)

Created:
3 years, 10 months ago by Jana
Modified:
3 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect behavior in checking for TCP FastOpen platform support. BUG=691881 Review-Url: https://codereview.chromium.org/2705323002 Cr-Commit-Position: refs/heads/master@{#452926} Committed: https://chromium.googlesource.com/chromium/src/+/6d9ba1044c884aca683404f05509f18d4b63c818

Patch Set 1 #

Total comments: 2

Patch Set 2 : Trim leading whitespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M net/socket/tcp_socket_posix.cc View 1 3 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Jana
I need to find someone in Chromium to approve this CL.
3 years, 10 months ago (2017-02-21 22:50:07 UTC) #2
Jana
3 years, 10 months ago (2017-02-21 23:14:40 UTC) #4
ycheng
lgtm
3 years, 10 months ago (2017-02-22 00:49:09 UTC) #5
Randy Smith (Not in Mondays)
Relying on ycheng's stamp to verify correct use of the system interface. LGTM but do ...
3 years, 10 months ago (2017-02-23 15:15:32 UTC) #6
Jana
Thanks, Randy, I've added whitespace trimming, PTAL. https://codereview.chromium.org/2705323002/diff/1/net/socket/tcp_socket_posix.cc File net/socket/tcp_socket_posix.cc (right): https://codereview.chromium.org/2705323002/diff/1/net/socket/tcp_socket_posix.cc#newcode101 net/socket/tcp_socket_posix.cc:101: !StringToInt(StringPiece(system_supports_tcp_fastopen), &read_int) ...
3 years, 9 months ago (2017-02-24 19:24:44 UTC) #7
Randy Smith (Not in Mondays)
lgtm
3 years, 9 months ago (2017-02-24 19:48:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705323002/20001
3 years, 9 months ago (2017-02-24 19:49:23 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-02-24 21:26:20 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6d9ba1044c884aca683404f05509...

Powered by Google App Engine
This is Rietveld 408576698