Fix incorrect behavior in checking for TCP FastOpen platform support.

Fix incorrect behavior in checking for TCP FastOpen platform support.

BUG=691881
Review-Url: https://codereview.chromium.org/2705323002
Cr-Commit-Position: refs/heads/master@{#452926}
Committed: https://chromium.googlesource.com/chromium/src/+/6d9ba1044c884aca683404f05509f18d4b63c818

[Jana, 2017-02-21 22:50:07]

jri@chromium.org changed reviewers:
+ ycheng@google.com

[Jana, 2017-02-21 22:50:07]

I need to find someone in Chromium to approve this CL.

[Jana, 2017-02-21 23:14:39]

jri@chromium.org changed reviewers:
+ rdsmith@chromium.org

[ycheng, 2017-02-22 00:49:09]

lgtm

[Randy Smith (Not in Mondays), 2017-02-23 15:15:32]

Relying on ycheng's stamp to verify correct use of the system interface.  LGTM
but do consider my question below.

https://codereview.chromium.org/2705323002/diff/1/net/socket/tcp_socket_posix.cc
File net/socket/tcp_socket_posix.cc (right):

https://codereview.chromium.org/2705323002/diff/1/net/socket/tcp_socket_posix...
net/socket/tcp_socket_posix.cc:101:
!StringToInt(StringPiece(system_supports_tcp_fastopen), &read_int) ||
Are you comfortable with this failing if there's leading whitespace?  The
documentation indicates that it'll return false in those circumstances.

[Jana, 2017-02-24 19:24:44]

Thanks, Randy, I've added whitespace trimming, PTAL.

https://codereview.chromium.org/2705323002/diff/1/net/socket/tcp_socket_posix.cc
File net/socket/tcp_socket_posix.cc (right):

https://codereview.chromium.org/2705323002/diff/1/net/socket/tcp_socket_posix...
net/socket/tcp_socket_posix.cc:101:
!StringToInt(StringPiece(system_supports_tcp_fastopen), &read_int) ||
On 2017/02/23 15:15:32, Randy Smith (Not in Mondays) wrote:
> Are you comfortable with this failing if there's leading whitespace?  The
> documentation indicates that it'll return false in those circumstances.

I've added whitespace trimming, PTAL.

[Randy Smith (Not in Mondays), 2017-02-24 19:48:16]

lgtm

[Jana, 2017-02-24 19:48:56]

The CQ bit was checked by jri@chromium.org

[Jana, 2017-02-24 19:48:56]

The patchset sent to the CQ was uploaded after l-g-t-m from ycheng@google.com
Link to the patchset: https://codereview.chromium.org/2705323002/#ps20001
(title: "Trim leading whitespace.")

[commit-bot: I haz the power, 2017-02-24 19:49:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 21:25:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487965736391140,
"parent_rev": "2373a62fb41a4efc063608ec2e16746df9ae53e6", "commit_rev":
"6d9ba1044c884aca683404f05509f18d4b63c818"}

[commit-bot: I haz the power, 2017-02-24 21:26:19]

Description was changed from

==========
Fix incorrect behavior in checking for TCP FastOpen platform support.

BUG=691881
==========

to

==========
Fix incorrect behavior in checking for TCP FastOpen platform support.

BUG=691881

Review-Url: https://codereview.chromium.org/2705323002
Cr-Commit-Position: refs/heads/master@{#452926}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d9ba1044c884aca683404f05509...
==========

[commit-bot: I haz the power, 2017-02-24 21:26:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6d9ba1044c884aca683404f05509...