Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2705303004: Use the right wording in DCHECK_IS_ON() presubmit check. (Closed)

Created:
3 years, 10 months ago by kjellander_chromium
Modified:
3 years, 10 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, danakj
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the right wording in DCHECK_IS_ON() presubmit check. It was added in https://codereview.chromium.org/1407033004/ but used the word braces for the parentheses. NOTRY=True Review-Url: https://codereview.chromium.org/2705303004 Cr-Commit-Position: refs/heads/master@{#452163} Committed: https://chromium.googlesource.com/chromium/src/+/aee30663ac9b7027fc013288f6cd5f21ebab5b6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M PRESUBMIT.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
kjellander_chromium
3 years, 10 months ago (2017-02-22 11:08:00 UTC) #4
Paweł Hajdan Jr.
LGTM
3 years, 10 months ago (2017-02-22 16:27:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705303004/1
3 years, 10 months ago (2017-02-22 19:20:58 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 19:27:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aee30663ac9b7027fc013288f6cd...

Powered by Google App Engine
This is Rietveld 408576698