Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2705273002: Throttle Socket watcher RTT notifications from QUIC (Closed)

Created:
3 years, 10 months ago by tbansal1
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Throttle Socket watcher RTT notifications from QUIC A QUIC connection can provide at most one RTT notification per second. This CL also refactors the code a little bit: (1) Moves the throttling logic from TCP Socket Posix to a common place: SocketWatcher, where it is used by both QUIC and TCP (2) Makes it possible to configure the throttling delay using field trial params. BUG=692119 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2690113004 Cr-Commit-Position: refs/heads/master@{#450967} (cherry picked from commit 180587c15a36861cdaaceec045619026e55fe8c5) Review-Url: https://codereview.chromium.org/2705273002 . Cr-Commit-Position: refs/branch-heads/2987@{#609} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/a7161971f69be0c7f27b1756a4ccfbd9896a98cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -82 lines) Patch
M net/net.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M net/nqe/network_quality_estimator.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/nqe/network_quality_estimator_params.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/nqe/network_quality_estimator_params.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/nqe/socket_watcher.h View 3 chunks +20 lines, -3 lines 0 comments Download
M net/nqe/socket_watcher.cc View 2 chunks +15 lines, -3 lines 0 comments Download
M net/nqe/socket_watcher_factory.h View 3 chunks +14 lines, -1 line 0 comments Download
M net/nqe/socket_watcher_factory.cc View 2 chunks +12 lines, -4 lines 0 comments Download
A net/nqe/socket_watcher_unittest.cc View 1 chunk +57 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_connection_logger.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/chromium/quic_network_transaction_unittest.cc View 6 chunks +77 lines, -6 lines 0 comments Download
M net/socket/tcp_socket_posix.h View 4 chunks +1 line, -14 lines 0 comments Download
M net/socket/tcp_socket_posix.cc View 5 chunks +1 line, -16 lines 0 comments Download
M net/socket/tcp_socket_unittest.cc View 5 chunks +13 lines, -33 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tbansal1
3 years, 10 months ago (2017-02-21 17:43:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7161971f69be0c7f27b1756a4ccfbd9896a98cc.

Powered by Google App Engine
This is Rietveld 408576698