Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2705253003: MIPS: Fix unaligned read and write in wasm-debug.cc (Closed)

Created:
3 years, 10 months ago by ivica.bogosavljevic
Modified:
3 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix unaligned read and write in wasm-debug.cc Fix crashes in two tests cctest/test-wasm-interpreter-entry/TestArgumentPassing_AllTypes and cctest/test-wasm-interpreter-entry/TestArgumentPassing_float_double related to accessing double value through unaligned pointer. This issue is present on those architectures that do not support unaligned access. TEST=cctest/test-wasm-interpreter-entry/TestArgumentPassing_AllTypes, cctest/test-wasm-interpreter-entry/TestArgumentPassing_float_double BUG= Review-Url: https://codereview.chromium.org/2705253003 Cr-Commit-Position: refs/heads/master@{#43387} Committed: https://chromium.googlesource.com/v8/v8/+/8e89201a4dccbb101ed60509a0474fda29d2f2e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/wasm/wasm-debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ivica.bogosavljevic
PTAL
3 years, 10 months ago (2017-02-22 15:31:49 UTC) #2
titzer
On 2017/02/22 15:31:49, ivica.bogosavljevic wrote: > PTAL lgtm
3 years, 10 months ago (2017-02-22 15:49:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705253003/1
3 years, 10 months ago (2017-02-23 10:52:50 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 10:54:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8e89201a4dccbb101ed60509a0474fda29d...

Powered by Google App Engine
This is Rietveld 408576698