chrome://profiler: Only show memory metrics in when heap tracking is enabled.

chrome://profiler: Only show memory metrics in when heap tracking is enabled.

BUG=644385
Review-Url: https://codereview.chromium.org/2705243002
Cr-Commit-Position: refs/heads/master@{#451783}
Committed: https://chromium.googlesource.com/chromium/src/+/3ee99d6d523ef55317ad8e33e0bc21550dfdf053

[Sigurður Ásgeirsson, 2017-02-21 15:46:56]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 15:47:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sigurður Ásgeirsson, 2017-02-21 15:49:54]

siggi@chromium.org changed reviewers:
+ bauerb@chromium.org, primiano@chromium.org

[Sigurður Ásgeirsson, 2017-02-21 15:49:54]

Hey Primiano,

This cuts down on clutter in the profiler when there aren't any memory metrics
to share. 
Bauer for OWNERS, pretty please.

Siggi

[Bernhard Bauer, 2017-02-21 15:52:44]

Web UI RS LGTM

[Primiano Tucci (use gerrit), 2017-02-21 16:08:58]

LGTM. I'd add reword the commit message to explain this is explicitly about the
UI, so won't confuse perf sheriffs and assign you any sort of memory regression
in the range :=)

I'd say:
chrome://profiler: Only show memory metrics in when heap tracking is enabled.

[Sigurður Ásgeirsson, 2017-02-21 16:09:39]

Description was changed from

==========
Only show memory metrics in task profiler when heap tracking enabled.

BUG=644385
==========

to

==========
chrome://profiler: Only show memory metrics in when heap tracking is enabled.

BUG=644385
==========

[Sigurður Ásgeirsson, 2017-02-21 16:10:00]

Thanks, so reworded.

On Tue, Feb 21, 2017 at 11:09 AM <primiano@chromium.org> wrote:

> LGTM. I'd add reword the commit message to explain this is explicitly
> about the
> UI, so won't confuse perf sheriffs and assign you any sort of memory
> regression
> in the range :=)
>
> I'd say:
> chrome://profiler: Only show memory metrics in when heap tracking is
> enabled.
>
> https://codereview.chromium.org/2705243002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-02-21 16:43:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 16:43:29]

Dry run: This issue passed the CQ dry run.

[Sigurður Ásgeirsson, 2017-02-21 16:43:46]

The CQ bit was checked by siggi@chromium.org

[commit-bot: I haz the power, 2017-02-21 16:44:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 17:07:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487695426191080, "parent_rev":
"02ea083631c24d912360e934e5e7231a92f330ed", "commit_rev":
"3ee99d6d523ef55317ad8e33e0bc21550dfdf053"}

[commit-bot: I haz the power, 2017-02-21 17:07:59]

Description was changed from

==========
chrome://profiler: Only show memory metrics in when heap tracking is enabled.

BUG=644385
==========

to

==========
chrome://profiler: Only show memory metrics in when heap tracking is enabled.

BUG=644385

Review-Url: https://codereview.chromium.org/2705243002
Cr-Commit-Position: refs/heads/master@{#451783}
Committed:
https://chromium.googlesource.com/chromium/src/+/3ee99d6d523ef55317ad8e33e0bc...
==========

[commit-bot: I haz the power, 2017-02-21 17:08:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ee99d6d523ef55317ad8e33e0bc...