[wasm] Enforce module size limit early enough

[wasm] Enforce module size limit early enough

The limit needs to be checked before casting the length to int in
ModuleWireBytes.

R=titzer@chromium.org
BUG=694433
Review-Url: https://codereview.chromium.org/2705233002
Cr-Commit-Position: refs/heads/master@{#43352}
Committed: https://chromium.googlesource.com/v8/v8/+/cc805e42af5ace69c5f52cc3fa50ed509a30fe28

[Clemens Hammacher, 2017-02-21 15:01:23]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 15:01:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 15:04:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 15:04:46]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/22993)

[titzer, 2017-02-21 15:10:22]

lgtm with nit

https://codereview.chromium.org/2705233002/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2705233002/diff/1/src/wasm/wasm-js.cc#newcode157
src/wasm/wasm-js.cc:157: static_cast<int64_t>(i::wasm::kV8MaxWasmModuleSize),
for size_t you can use %zu as the format string.

[Clemens Hammacher, 2017-02-21 17:30:53]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 17:30:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2017-02-21 17:35:59]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 17:36:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2017-02-21 17:48:16]

Looking at the code again, I realized that we always computed end as "start +
length", and length was already size_t. So instead of storing <start, end>, I
now store <start, length> inside the method, which avoids some casting and makes
the code more clear IMO.
PTAL.

https://codereview.chromium.org/2705233002/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2705233002/diff/1/src/wasm/wasm-js.cc#newcode157
src/wasm/wasm-js.cc:157: static_cast<int64_t>(i::wasm::kV8MaxWasmModuleSize),
On 2017/02/21 at 15:10:22, titzer wrote:
> for size_t you can use %zu as the format string.

Done.

[titzer, 2017-02-21 17:50:55]

lgtm
in fact,
lebtm (looks even better to me)

[commit-bot: I haz the power, 2017-02-21 18:00:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 18:00:41]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2017-02-21 18:11:16]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2017-02-21 18:11:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 18:13:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487700676979380,
"parent_rev": "fa5304d1aad94d08fcc17c22e9ec03bf7ea4c295", "commit_rev":
"cc805e42af5ace69c5f52cc3fa50ed509a30fe28"}

[commit-bot: I haz the power, 2017-02-21 18:13:06]

Description was changed from

==========
[wasm] Enforce module size limit early enough

The limit needs to be checked before casting the length to int in
ModuleWireBytes.

R=titzer@chromium.org
BUG=694433
==========

to

==========
[wasm] Enforce module size limit early enough

The limit needs to be checked before casting the length to int in
ModuleWireBytes.

R=titzer@chromium.org
BUG=694433

Review-Url: https://codereview.chromium.org/2705233002
Cr-Commit-Position: refs/heads/master@{#43352}
Committed:
https://chromium.googlesource.com/v8/v8/+/cc805e42af5ace69c5f52cc3fa50ed509a3...
==========

[commit-bot: I haz the power, 2017-02-21 18:13:07]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/cc805e42af5ace69c5f52cc3fa50ed509a3...