Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2705223003: color: Fix accidental partial color conversion (Closed)

Created:
3 years, 10 months ago by ccameron
Modified:
3 years, 10 months ago
Reviewers:
hubbe
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3018
Project:
chromium
Visibility:
Public.

Description

color: Fix accidental partial color conversion For color spaces that can't be represented by an matrix plus analytic transfer function, we need to ensure that we don't accidentally enable color conversion when the destination is undefined. Tests may be disruptive and are in a separate patch. BUG=694191 R=hubbe@chromium.org Review-Url: https://codereview.chromium.org/2712533002 . Cr-Commit-Position: refs/heads/master@{#451858} (cherry picked from commit 1d14a77942910d9f60af73c674809b1f82de3847) Review-Url: https://codereview.chromium.org/2705223003 . Cr-Commit-Position: refs/branch-heads/3018@{#3} Cr-Branched-From: 5e7216844858ad1d08a70ac7aeef88547db2be7f-refs/heads/master@{#451537} Committed: https://chromium.googlesource.com/chromium/src/+/1e5ed6bb29f1884453c279a4427a94054bf343f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M ui/gfx/color_transform.cc View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ccameron
3 years, 10 months ago (2017-02-22 00:53:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e5ed6bb29f1884453c279a4427a94054bf343f2.

Powered by Google App Engine
This is Rietveld 408576698