Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2705213007: [Video] MediaSession API event handlers can resume background video. (Closed)

Created:
3 years, 9 months ago by whywhat
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Video] MediaSession API event handlers can resume background video. ShouldPauseVideoWhenHidden is now used for videos with audio too so that HTMLMediaElement::play() actually reaches WMPI because the video is paused. WMPI::UpdatePlayState_ComputePlayState now only cares about the presence of the session and allows playback of anything as long as it got play() command. WMPI now tracks whether background video playback has been unlocked by a user gesture. RendererWebMediaPlayerDelegate emulates user gesture in OnPlay/OnPause to behave the same way as MediaSession. BUG=689637 TEST=manual+updated tests Review-Url: https://codereview.chromium.org/2681863005 Cr-Commit-Position: refs/heads/master@{#452700} (cherry picked from commit 65fad2795b571f868c559941187f785aaa0414a0) R=sandersd@chromium.org Review-Url: https://codereview.chromium.org/2705213007 . Cr-Commit-Position: refs/branch-heads/2987@{#682} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/a8ce00278da90b8abbdf39b0f74ddbb417e0035e

Patch Set 1 #

Patch Set 2 : Removed non-existing argument in the test #

Patch Set 3 : Fixed WMPA #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -258 lines) Patch
M content/browser/media/session/media_session_impl_visibility_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 6 chunks +16 lines, -2 lines 0 comments Download
M content/renderer/media/renderer_webmediaplayer_delegate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/media/renderer_webmediaplayer_delegate.cc View 6 chunks +14 lines, -17 lines 0 comments Download
M content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc View 2 chunks +0 lines, -39 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 12 chunks +65 lines, -56 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 1 6 chunks +241 lines, -136 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
whywhat
Removed non-existing argument in the test
3 years, 9 months ago (2017-02-24 01:33:58 UTC) #1
whywhat
Fixed WMPA
3 years, 9 months ago (2017-02-24 18:25:48 UTC) #2
whywhat
Dan, would you please take a look at the WMPA change for a sanity check? ...
3 years, 9 months ago (2017-02-24 18:27:27 UTC) #4
sandersd (OOO until July 31)
lgtm
3 years, 9 months ago (2017-02-24 20:23:53 UTC) #5
whywhat
3 years, 9 months ago (2017-02-24 21:51:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
a8ce00278da90b8abbdf39b0f74ddbb417e0035e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698