Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc

Issue 2705213005: Add NativePixmapDmabufStub to finalize glCreateImageCHROMIUM on Linux. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/ipc/service/BUILD.gn ('k') | ui/gfx/BUILD.gn » ('j') | ui/gfx/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc
diff --git a/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc b/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc
index 77b68af8f821f0bcc14af12ae00e757fe4d1df53..b89aea8485cf0dea67f88f7809fda68c520d59f9 100644
--- a/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc
+++ b/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc
@@ -11,6 +11,8 @@
#if defined(USE_OZONE)
#include "ui/ozone/public/ozone_platform.h"
#include "ui/ozone/public/surface_factory_ozone.h"
+#elif defined(OS_LINUX)
+#include "ui/gfx/linux/native_pixmap_dmabuf_stub.h"
#endif
namespace gpu {
@@ -101,8 +103,8 @@ GpuMemoryBufferFactoryNativePixmap::CreateImageForGpuMemoryBuffer(
->CreateNativePixmapFromHandle(surface_handle, size, format,
handle.native_pixmap_handle);
#else
- // TODO(j.isorce): implement this to enable glCreateImageCHROMIUM on Linux.
- NOTIMPLEMENTED();
+ pixmap = new ui::NativePixmapDmaBufStub(size, format,
reveman 2017/04/12 18:21:36 should we be using make_scoped_refptr here to make
Julien Isorce 2017/04/13 12:46:02 Sure, I will do it.
+ handle.native_pixmap_handle);
#endif
if (!pixmap.get()) {
DLOG(ERROR) << "Failed to create pixmap from handle";
« no previous file with comments | « gpu/ipc/service/BUILD.gn ('k') | ui/gfx/BUILD.gn » ('j') | ui/gfx/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698