Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2705213005: Add NativePixmapDmabufStub to finalize glCreateImageCHROMIUM on Linux.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by Julien Isorce
Modified:
5 days, 2 hours ago
Reviewers:
reveman, sadrul, spang
CC:
chromium-reviews, piman+watch_chromium.orgigalia.com, tonikitoo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add NativePixmapDmabufStub to finalize glCreateImageCHROMIUM on Linux. This class is just a stub to hold dmabuf in order to be passed to GLImageNativePixmap::Initialize(NativePixmap*). This complete enablement of glCreateImageCHROMIUM with linux dma buf on linux. BUG=584248 R=reveman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 6

Patch Set 3 : Just rebase #

Patch Set 4 : Addressed some review remarks and fixed build #

Patch Set 5 : Rebase and addressed remarks #

Total comments: 4

Patch Set 6 : Rename NativePixmapDmabufStub to NativePixmapDmabuf #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Patch Set 9 : Rebase #

Patch Set 10 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -3 lines) Patch
M gpu/ipc/service/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
A ui/gfx/linux/native_pixmap_dmabuf.h View 1 2 3 4 5 1 chunk +58 lines, -0 lines 0 comments Download
A ui/gfx/linux/native_pixmap_dmabuf.cc View 1 2 3 4 5 1 chunk +87 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 49 (37 generated)
reveman
https://codereview.chromium.org/2705213005/diff/20001/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc File gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc (right): https://codereview.chromium.org/2705213005/diff/20001/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc#newcode106 gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc:106: pixmap = new ui::NativePixmapDmaBufStub(size, format, should we be using ...
1 month, 1 week ago (2017-04-12 18:21:37 UTC) #4
Julien Isorce
Thx for the review, here are my replies: https://codereview.chromium.org/2705213005/diff/20001/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc File gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc (right): https://codereview.chromium.org/2705213005/diff/20001/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc#newcode106 gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc:106: pixmap ...
1 month, 1 week ago (2017-04-13 12:46:02 UTC) #9
Julien Isorce
> https://codereview.chromium.org/2705213005/diff/20001/ui/gfx/BUILD.gn#newcode496 > ui/gfx/BUILD.gn:496: "//gpu/ipc/service:ipc_service_sources", > On 2017/04/12 18:21:36, reveman wrote: > > why is ...
1 month, 1 week ago (2017-04-14 09:59:42 UTC) #15
spang1
On 2017/04/14 09:59:42, Julien Isorce wrote: > > > https://codereview.chromium.org/2705213005/diff/20001/ui/gfx/BUILD.gn#newcode496 > > ui/gfx/BUILD.gn:496: "//gpu/ipc/service:ipc_service_sources", > ...
1 month ago (2017-04-18 18:59:44 UTC) #16
Julien Isorce
On 2017/04/18 18:59:44, spang1 wrote: > On 2017/04/14 09:59:42, Julien Isorce wrote: > > > ...
1 month ago (2017-04-19 12:06:23 UTC) #21
Julien Isorce
Please take a look to patch set 5, thx!
1 month ago (2017-04-19 12:07:56 UTC) #22
spang
lgtm https://codereview.chromium.org/2705213005/diff/80001/ui/gfx/linux/native_pixmap_dmabuf_stub.cc File ui/gfx/linux/native_pixmap_dmabuf_stub.cc (right): https://codereview.chromium.org/2705213005/diff/80001/ui/gfx/linux/native_pixmap_dmabuf_stub.cc#newcode79 ui/gfx/linux/native_pixmap_dmabuf_stub.cc:79: { Wrong whitespace, please run clang-format / git ...
1 month ago (2017-04-21 15:11:49 UTC) #23
Julien Isorce
Thx for the review. Remarks addressed in Patch Set 6. https://codereview.chromium.org/2705213005/diff/80001/ui/gfx/linux/native_pixmap_dmabuf_stub.cc File ui/gfx/linux/native_pixmap_dmabuf_stub.cc (right): https://codereview.chromium.org/2705213005/diff/80001/ui/gfx/linux/native_pixmap_dmabuf_stub.cc#newcode79 ...
1 month ago (2017-04-24 12:26:00 UTC) #24
Julien Isorce
Hi @reveman, please take a look. Thx!
3 weeks, 6 days ago (2017-04-27 13:49:43 UTC) #33
Julien Isorce
Hi sadrul, PTAL at ui/gfx/*. Thank you!
1 week, 6 days ago (2017-05-11 09:00:22 UTC) #37
sadrul
On 2017/05/11 09:00:22, Julien Isorce wrote: > Hi sadrul, PTAL at ui/gfx/*. Thank you! reveman@ ...
1 week, 5 days ago (2017-05-12 17:10:20 UTC) #40
Julien Isorce
6 days, 2 hours ago (2017-05-18 15:01:40 UTC) #41
On 2017/05/12 17:10:20, sadrul wrote:
> On 2017/05/11 09:00:22, Julien Isorce wrote:
> > Hi sadrul, PTAL at ui/gfx/*. Thank you!
> 
> reveman@ should review.

Hi David, gentle ping for review. Thx.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06