Show different error message if ARC is disabled.

Show different error message if ARC is disabled.

If DM Server returns a 904 Arc Disabled error code when getting an
enrollment token then show a different error message to the user on the
ARC login screen.

BUG=694542
Review-Url: https://codereview.chromium.org/2705213002
Cr-Commit-Position: refs/heads/master@{#455081}
Committed: https://chromium.googlesource.com/chromium/src/+/86e08ee7912c3c9bb87e98474ccb9ed21f86753a

[Marton Hunyady, 2017-02-21 14:06:51]

hunyadym@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Marton Hunyady, 2017-02-21 14:06:52]

PTAL

This is based on https://codereview.chromium.org/2704113003/

[Marton Hunyady, 2017-02-21 16:07:08]

hunyadym@chromium.org changed reviewers:
+ tnagel@chromium.org

[Marton Hunyady, 2017-02-21 16:07:08]

tnagel@chromium.org: Please review changes in
chrome/browser/policy/cloud/test_request_interceptor.*

[Luis Héctor Chávez, 2017-02-21 19:32:11]

https://codereview.chromium.org/2705213002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/auth/arc_auth_info_fetcher.h (right):

https://codereview.chromium.org/2705213002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/auth/arc_auth_info_fetcher.h:18: SIZE,          //
The size of this enum; keep last.
Do you *need* the SIZE? Seems like you're only using this in tests and not for
UMA purposes, so you should be able to remove it and also remove all default:
labels in all the switch blocks where you use ArcAuthInfoFetchStatus, that way
the compiler will complain if you are not being exhaustive in the switch.

Also, how about moving this enum into ArcAuthInfoFetcher? That way it will be
ArcAuthInfoFetcher::Status :)

https://codereview.chromium.org/2705213002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/auth/arc_auth_info_fetcher.h:27: // On success,
|callback| is called with status = SUCCESS and with the fetched
nit: "|status|". Same below.

[Marton Hunyady, 2017-02-22 16:07:54]

https://codereview.chromium.org/2705213002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/auth/arc_auth_info_fetcher.h (right):

https://codereview.chromium.org/2705213002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/auth/arc_auth_info_fetcher.h:18: SIZE,          //
The size of this enum; keep last.
On 2017/02/21 19:32:11, Luis Héctor Chávez wrote:
> Do you *need* the SIZE? Seems like you're only using this in tests and not for
> UMA purposes, so you should be able to remove it and also remove all default:
> labels in all the switch blocks where you use ArcAuthInfoFetchStatus, that way
> the compiler will complain if you are not being exhaustive in the switch.
> 
> Also, how about moving this enum into ArcAuthInfoFetcher? That way it will be
> ArcAuthInfoFetcher::Status :)

Done. (This also means I can't forward declare it in arc_auth_service.h)

https://codereview.chromium.org/2705213002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/auth/arc_auth_info_fetcher.h:27: // On success,
|callback| is called with status = SUCCESS and with the fetched
On 2017/02/21 19:32:11, Luis Héctor Chávez wrote:
> nit: "|status|". Same below.

Done.

[Luis Héctor Chávez, 2017-02-22 17:15:30]

chrome/browser/chromeos/arc/ lgtm

[Marton Hunyady, 2017-03-02 11:35:17]

Description was changed from

==========
Show different error message if ARC is disabled.

If DM Server returns a 904 Arc Disabled error code when getting an
enrollment token then show a different error message to the user on the
ARC login screen.

BUG=694542
==========

to

==========
Show different error message if ARC is disabled.

If DM Server returns a 904 Arc Disabled error code when getting an
enrollment token then show a different error message to the user on the
ARC login screen.

BUG=694542
==========

[Marton Hunyady, 2017-03-02 11:35:17]

hunyadym@chromium.org changed reviewers:
+ pastarmovj@chromium.org
- tnagel@chromium.org

[pastarmovj, 2017-03-02 12:15:49]

lgtm

[Marton Hunyady, 2017-03-07 14:54:15]

The CQ bit was checked by hunyadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 14:55:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 15:29:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 15:29:55]

Dry run: This issue passed the CQ dry run.

[Marton Hunyady, 2017-03-07 15:30:13]

The CQ bit was checked by hunyadym@chromium.org

[Marton Hunyady, 2017-03-07 15:30:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org, pastarmovj@chromium.org
Link to the patchset: https://codereview.chromium.org/2705213002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-07 15:30:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 15:36:31]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488900613721260,
"parent_rev": "ff0155c8b55abcc8ce9fa54cd7af315f3e357968", "commit_rev":
"86e08ee7912c3c9bb87e98474ccb9ed21f86753a"}

[commit-bot: I haz the power, 2017-03-07 15:37:11]

Description was changed from

==========
Show different error message if ARC is disabled.

If DM Server returns a 904 Arc Disabled error code when getting an
enrollment token then show a different error message to the user on the
ARC login screen.

BUG=694542
==========

to

==========
Show different error message if ARC is disabled.

If DM Server returns a 904 Arc Disabled error code when getting an
enrollment token then show a different error message to the user on the
ARC login screen.

BUG=694542

Review-Url: https://codereview.chromium.org/2705213002
Cr-Commit-Position: refs/heads/master@{#455081}
Committed:
https://chromium.googlesource.com/chromium/src/+/86e08ee7912c3c9bb87e98474ccb...
==========

[commit-bot: I haz the power, 2017-03-07 15:37:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/86e08ee7912c3c9bb87e98474ccb...