Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2705193006: Revert of Add Widevine signature files into Mac build (patchset #8 id:140001 of https://codereview.… (Closed)

Created:
3 years, 10 months ago by Robert Sesek
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3022
Project:
chromium
Visibility:
Public.

Description

Revert of Add Widevine signature files into Mac build (patchset #8 id:140001 of https://codereview.chromium.org/2647393004/ ) Reason for revert: Broke official build https://crbug.com/695761 BUG=695761 Original issue's description: > Add Widevine signature files into Mac build > > On official Mac builds Widevine is included in the app. This change adds > the matching signature files needed by Widevine. > > BUG=684871 > TEST=signature files created in the correct place when is_official_build > > Review-Url: https://codereview.chromium.org/2647393004 > Cr-Commit-Position: refs/heads/master@{#452603} > Committed: https://chromium.googlesource.com/chromium/src/+/5762e61a17e4e05c490be128fd96204f24c1a457 TBR=xhwang@chromium.org,rkuroiwa@chromium.org,kerrnel@chromium.org,dpranke@chromium.org,jrummell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=684871 Review-Url: https://codereview.chromium.org/2714643009 Cr-Commit-Position: refs/heads/master@{#452832} (cherry picked from commit 72d281d8c6fc0e2c94c2545c7d6c7ad7409324e7) Review-Url: https://codereview.chromium.org/2705193006 . Cr-Commit-Position: refs/branch-heads/3022@{#3} Cr-Branched-From: 55a8e3f7414855960a20135217d32de930466f3d-refs/heads/master@{#452713} Committed: https://chromium.googlesource.com/chromium/src/+/d774c481f48e6c49ec929207ae6c376143022b93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -75 lines) Patch
M chrome/BUILD.gn View 3 chunks +0 lines, -39 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/widevine/cdm/widevine.gni View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Robert Sesek
Committed patchset #1 (id:1) manually as d774c481f48e6c49ec929207ae6c376143022b93.
3 years, 10 months ago (2017-02-24 18:25:18 UTC) #2
Dirk Pranke
3 years, 10 months ago (2017-02-24 21:50:04 UTC) #3
Message was sent while issue was closed.
rs -lgtm. I've totally lost track of what's in or out at this point.

Powered by Google App Engine
This is Rietveld 408576698