Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2705193004: linked_ptr->unique_ptr in system_indicator_manager.cc/h (Closed)

Created:
3 years, 10 months ago by lazyboy
Modified:
3 years, 9 months ago
Reviewers:
dewittj
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

linked_ptr->unique_ptr in system_indicator_manager.cc/h BUG=556939 Review-Url: https://codereview.chromium.org/2705193004 Cr-Commit-Position: refs/heads/master@{#453464} Committed: https://chromium.googlesource.com/chromium/src/+/bb8918a60b725d1d528869b4502cca2ed366839f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M chrome/browser/extensions/api/system_indicator/system_indicator_manager.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc View 5 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
lazyboy
3 years, 10 months ago (2017-02-23 22:25:35 UTC) #7
lazyboy
3 years, 10 months ago (2017-02-23 22:25:40 UTC) #8
dewittj
lgtm
3 years, 9 months ago (2017-02-27 17:36:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705193004/1
3 years, 9 months ago (2017-02-28 01:16:47 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 02:25:41 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bb8918a60b725d1d528869b4502c...

Powered by Google App Engine
This is Rietveld 408576698