Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2705153003: Fix locale ids for a few languages in the GCP printer inf file. (Closed)

Created:
3 years, 10 months ago by pastarmovj
Modified:
3 years, 10 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix locale ids for a few languages in the GCP printer inf file. The difference is the most probable cause for installation errors on locales other than English. BUG=684102 TEST=manual in a VM with spanish Windows. Review-Url: https://codereview.chromium.org/2705153003 Cr-Commit-Position: refs/heads/master@{#451718} Committed: https://chromium.googlesource.com/chromium/src/+/f384edd5ac54a0f81cd1f4be3bb271d6502c85cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M cloud_print/virtual_driver/win/install/inf/gcp_driver.inf View Binary file 0 comments Download

Messages

Total messages: 8 (4 generated)
pastarmovj
Please stamp :)
3 years, 10 months ago (2017-02-21 09:04:38 UTC) #2
bartfab (slow)
lgtm
3 years, 10 months ago (2017-02-21 09:12:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705153003/1
3 years, 10 months ago (2017-02-21 09:15:08 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 09:55:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f384edd5ac54a0f81cd1f4be3bb2...

Powered by Google App Engine
This is Rietveld 408576698