Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2705043002: Added use counters for document.origin and document.location.origin (Closed)

Created:
3 years, 10 months ago by andypaicu
Modified:
3 years, 10 months ago
Reviewers:
Mike West
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added use counters for document.origin and document.location.origin This is to get data in preparation for deprecation in favour of self.origin BUG=692084 Review-Url: https://codereview.chromium.org/2705043002 Cr-Commit-Position: refs/heads/master@{#451721} Committed: https://chromium.googlesource.com/chromium/src/+/c0b859fac8e08efe01b4871e00558162ade4c644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Location.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
andypaicu
3 years, 10 months ago (2017-02-20 11:56:09 UTC) #3
Mike West
lgtm
3 years, 10 months ago (2017-02-20 12:21:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705043002/1
3 years, 10 months ago (2017-02-20 12:21:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/391805)
3 years, 10 months ago (2017-02-20 14:32:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705043002/1
3 years, 10 months ago (2017-02-21 10:01:20 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 10:26:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c0b859fac8e08efe01b4871e0055...

Powered by Google App Engine
This is Rietveld 408576698