runtime/vm/benchmark_test.cc - Issue 270503007: Eliminate unused url mapping parameter in dartutils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/benchmark_test.cc

Issue 270503007: Eliminate unused url mapping parameter in dartutils (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/benchmark_test.cc

===================================================================

--- runtime/vm/benchmark_test.cc (revision 35950)

+++ runtime/vm/benchmark_test.cc (working copy)

@@ -438,7 +438,7 @@

// Start an Isolate, load a script and create a full snapshot.

uint8_t* buffer;

- TestCase::LoadTestScript(kScriptChars, NULL);

+ TestCase::LoadCoreTestScript(kScriptChars, NULL);

Ivan Posva 2014/05/09 06:31:35 Please add a comment explaining why LoadCoreTestSc

hausner 2014/05/09 17:07:18 Done. Yes, it's because importing dart:_internal c

Api::CheckIsolateState(Isolate::Current());

// Write snapshot with object content.

@@ -467,7 +467,7 @@

// Start an Isolate, load a script and create a full snapshot.

uint8_t* buffer;

- TestCase::LoadTestScript(kScriptChars, NULL);

+ TestCase::LoadCoreTestScript(kScriptChars, NULL);

Ivan Posva 2014/05/09 06:31:35 ditto

hausner 2014/05/09 17:07:18 Done.

Api::CheckIsolateState(Isolate::Current());

// Write snapshot with object content.

« no previous file with comments | « runtime/bin/gen_snapshot.cc ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | runtime/vm/dart_api_impl_test.cc » ('J')