Eliminate unused url mapping parameter in dartutils

runtime/vm/benchmark_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/benchmark_test.h"
 
 #include "bin/builtin.h"
 #include "bin/file.h"
 
 #include "platform/assert.h"
@@ skipping 420 matching lines @@
       "import 'dart:collection';\n"
       "import 'dart:_internal';\n"
       "import 'dart:math';\n"
       "import 'dart:isolate';\n"
       "import 'dart:mirrors';\n"
       "import 'dart:typed_data';\n"
       "\n";
 
   // Start an Isolate, load a script and create a full snapshot.
   uint8_t* buffer;
-  TestCase::LoadTestScript(kScriptChars, NULL);
+  TestCase::LoadCoreTestScript(kScriptChars, NULL);

[Ivan Posva, 2014/05/09 06:31:35]

Please add a comment explaining why LoadCoreTestScript was needed here. As far
as I understand it is due to the dart:_internal import, but it would be good to
document this fact.

[hausner, 2014/05/09 17:07:18]

Done. Yes, it's because importing dart:_internal can only be done from a dart:
library.

   Api::CheckIsolateState(Isolate::Current());
 
   // Write snapshot with object content.
   FullSnapshotWriter writer(&buffer, &malloc_allocator);
   writer.WriteFullSnapshot();
   const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
   ASSERT(snapshot->kind() == Snapshot::kFull);
   benchmark->set_score(snapshot->length());
 }
 
 
 BENCHMARK(StandaloneSnapshotSize) {
   const char* kScriptChars =
       "import 'dart:async';\n"
       "import 'dart:core';\n"
       "import 'dart:collection';\n"
       "import 'dart:_internal';\n"
       "import 'dart:convert';\n"
       "import 'dart:math';\n"
       "import 'dart:isolate';\n"
       "import 'dart:mirrors';\n"
       "import 'dart:typed_data';\n"
       "import 'dart:builtin';\n"
       "import 'dart:io';\n"
       "\n";
 
   // Start an Isolate, load a script and create a full snapshot.
   uint8_t* buffer;
-  TestCase::LoadTestScript(kScriptChars, NULL);
+  TestCase::LoadCoreTestScript(kScriptChars, NULL);

[Ivan Posva, 2014/05/09 06:31:35]

ditto

[hausner, 2014/05/09 17:07:18]

Done.

   Api::CheckIsolateState(Isolate::Current());
 
   // Write snapshot with object content.
   FullSnapshotWriter writer(&buffer, &malloc_allocator);
   writer.WriteFullSnapshot();
   const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
   ASSERT(snapshot->kind() == Snapshot::kFull);
   benchmark->set_score(snapshot->length());
 }
 
@@ skipping 106 matching lines @@
     SnapshotReader reader(buffer, buffer_len, Snapshot::kMessage, isolate);
     reader.ReadObject();
     free(buffer);
   }
   timer.Stop();
   int64_t elapsed_time = timer.TotalElapsedTime();
   benchmark->set_score(elapsed_time);
 }
 
 }  // namespace dart