Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2704993002: Don't handle the key events with Command (Search) modifier by IME. (Closed)

Created:
3 years, 10 months ago by Shu Chen
Modified:
3 years, 10 months ago
Reviewers:
Azure Wei
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't handle the key events with Command (Search) modifier by IME. BUG=686997 Review-Url: https://codereview.chromium.org/2704993002 Cr-Commit-Position: refs/heads/master@{#451579} Committed: https://chromium.googlesource.com/chromium/src/+/6fbd37145e9b8eb98e1e5b330364db3fd07dd719

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/input_method/input_method_engine_base.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Shu Chen
Lan, can you please review this cl? Thanks.
3 years, 10 months ago (2017-02-20 07:04:04 UTC) #2
Azure Wei
lgtm
3 years, 10 months ago (2017-02-20 07:42:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704993002/1
3 years, 10 months ago (2017-02-20 08:02:30 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 08:07:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6fbd37145e9b8eb98e1e5b330364...

Powered by Google App Engine
This is Rietveld 408576698