Make security checks in BitVector not just debug

Make security checks in BitVector not just debug

In order to be more certain that UseCounters never write outside the
bounds of the BitVectors they use, this patch converts the
SECURITY_DCHECK statements in BitVector.h to SECURITY_CHECK.

BUG=458925
Review-Url: https://codereview.chromium.org/2704953002
Cr-Commit-Position: refs/heads/master@{#454819}
Committed: https://chromium.googlesource.com/chromium/src/+/c9500f1d6491a41b4222f883a60b84ad3fd82734

[suzyh_UTC10 (ex-contributor), 2017-02-20 20:44:27]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 20:44:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 22:10:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 22:10:08]

Dry run: This issue passed the CQ dry run.

[suzyh_UTC10 (ex-contributor), 2017-02-20 22:32:18]

For the record: I am attempting to determine if there is a performance
regression due to this change. So far I have run the following commands against
this patch:

$ tools/perf/run_benchmark try all blink_perf.css
$ git cl try -m tryserver.chromium.perf

[suzyh_UTC10 (ex-contributor), 2017-02-20 22:40:44]

On 2017/02/20 at 22:32:18, suzyh wrote:
> For the record: I am attempting to determine if there is a performance
regression due to this change. So far I have run the following commands against
this patch:
> 
> $ tools/perf/run_benchmark try all blink_perf.css
> $ git cl try -m tryserver.chromium.perf

Now trying
$ tools/perf/run_benchmark try all-android memory.top_10_mobile

[suzyh_UTC10 (ex-contributor), 2017-02-21 03:05:42]

suzyh@chromium.org changed reviewers:
+ rbyers@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-02-21 03:07:06]

Having sent this to some perf bots... rbyers: Are you happy with this result? Is
there something else I should test?

[Rick Byers, 2017-02-24 22:14:56]

rbyers@chromium.org changed reviewers:
+ tkent@chromium.org

[Rick Byers, 2017-02-24 22:14:57]

Yeah if the perf try bots are happy then I think we should just land this.  It
seems likely to be worth the tiny extra cost to me.

But since this is WTF, you should get a WTF/OWNER to review.  tkent@ WDYT?  This
came up when looking at UseCounter code - we were fairly confident an overflow
wasn't possible, but I said I'd prefer if we were 100% certain given the
security implication.

[tkent, 2017-02-26 20:17:13]

lgtm

[suzyh_UTC10 (ex-contributor), 2017-03-06 00:08:47]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2017-03-06 00:09:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 03:48:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488758927692400, "parent_rev":
"42bca36878d20e2bf6f27fb091d61d01ddc516a9", "commit_rev":
"c9500f1d6491a41b4222f883a60b84ad3fd82734"}

[commit-bot: I haz the power, 2017-03-06 03:49:19]

Description was changed from

==========
Make security checks in BitVector not just debug

In order to be more certain that UseCounters never write outside the
bounds of the BitVectors they use, this patch converts the
SECURITY_DCHECK statements in BitVector.h to SECURITY_CHECK.

BUG=458925
==========

to

==========
Make security checks in BitVector not just debug

In order to be more certain that UseCounters never write outside the
bounds of the BitVectors they use, this patch converts the
SECURITY_DCHECK statements in BitVector.h to SECURITY_CHECK.

BUG=458925

Review-Url: https://codereview.chromium.org/2704953002
Cr-Commit-Position: refs/heads/master@{#454819}
Committed:
https://chromium.googlesource.com/chromium/src/+/c9500f1d6491a41b4222f883a60b...
==========

[commit-bot: I haz the power, 2017-03-06 03:49:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c9500f1d6491a41b4222f883a60b...