Cast: Deduplicate event types in cast library.

Cast: Deduplicate event types in cast library.

- Remove k{Audio,Video}XXX event types and add in kXXX event types to
be shared between audio and video.
- Changed RTCP event mapping to accept both k{A,V}XXX and kXXX event
type encodings from the receiver. Old encodings get mapped to the
unified types on sender side.
- Changed reciever reference implementation to always send new unified
event types.
- Changed LoggingImpl::Insert{Frame,Packet}Event calls to take
additional EventMediaType argument.
- Added a param in RTCP to indicate whether receiver events
from incoming ssrc are audio or video events.
- Remove generic event types.
- Remove other unused events
-- kVideoFrameSentToEncoder
-- k{AV}PacketSentToPacer
-- kDuplicate{AV}PacketReceived


BUG=365829
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269473

[Alpha Left Google, 2014-05-07 05:12:52]

Is the log reporting still intact with a receiver with this change?

[imcheng, 2014-05-07 07:11:20]

Receiver to sender report: The mapping in rtcp_receiver.cc can handle encoding
from either a receiver sending the old events or new events.

Sender to receiver report: I have made some changes since we are removing
kVideoFrameSentToEncoder event, but it should have no impact since nobody is
using it, and we are removing it anyway.

[Alpha Left Google, 2014-05-07 17:57:23]

Okay. LGTM.

[Alpha Left Google, 2014-05-07 17:57:27]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-05-07 17:58:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/imcheng@chromium.org/270493003/20001

[imcheng, 2014-05-07 18:44:41]

The CQ bit was checked by imcheng@chromium.org

[commit-bot: I haz the power, 2014-05-07 18:48:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/imcheng@chromium.org/270493003/40001

[commit-bot: I haz the power, 2014-05-07 23:27:44]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
  win_chromium_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-08 03:40:34]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
  win_chromium_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-08 04:24:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-08 04:24:41]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium

[imcheng, 2014-05-08 04:55:00]

The CQ bit was checked by imcheng@chromium.org

[commit-bot: I haz the power, 2014-05-08 04:56:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/imcheng@chromium.org/270493003/40001

[commit-bot: I haz the power, 2014-05-08 18:32:23]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-08 22:45:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-08 22:45:43]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[imcheng, 2014-05-08 22:48:02]

The CQ bit was checked by imcheng@chromium.org

[commit-bot: I haz the power, 2014-05-08 22:55:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/imcheng@chromium.org/270493003/40001

[commit-bot: I haz the power, 2014-05-09 05:54:08]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-09 13:34:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 13:34:27]

Failed to apply patch for media/cast/audio_sender/audio_encoder.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file media/cast/audio_sender/audio_encoder.cc
  Hunk #1 FAILED at 23.
  Hunk #2 FAILED at 104.
  2 out of 2 hunks FAILED -- saving rejects to file
media/cast/audio_sender/audio_encoder.cc.rej

Patch:       media/cast/audio_sender/audio_encoder.cc
Index: media/cast/audio_sender/audio_encoder.cc
diff --git a/media/cast/audio_sender/audio_encoder.cc
b/media/cast/audio_sender/audio_encoder.cc
index
ab5adf49d25a173813bc840e748e7385e9262c83..e7f94f5ea9e613de6191ab4dea4dce9d6b0ce304
100644
--- a/media/cast/audio_sender/audio_encoder.cc
+++ b/media/cast/audio_sender/audio_encoder.cc
@@ -23,12 +23,12 @@ namespace {
 void LogAudioFrameEncodedEvent(
     const scoped_refptr<media::cast::CastEnvironment>& cast_environment,
     base::TimeTicks event_time,
-    media::cast::CastLoggingEvent event_type,
     media::cast::RtpTimestamp rtp_timestamp,
     uint32 frame_id,
     size_t frame_size) {
   cast_environment->Logging()->InsertEncodedFrameEvent(
-      event_time, event_type, rtp_timestamp, frame_id,
+      event_time, media::cast::FRAME_ENCODED, media::cast::AUDIO_EVENT,
+      rtp_timestamp, frame_id,
       static_cast<int>(frame_size), /* key_frame - unused */ false,
       /*target_bitrate - unused*/ 0);
 }
@@ -104,7 +104,6 @@ class AudioEncoder::ImplBase
               base::Bind(&LogAudioFrameEncodedEvent,
                          cast_environment_,
                          cast_environment_->Clock()->NowTicks(),
-                         kAudioFrameEncoded,
                          audio_frame->rtp_timestamp,
                          audio_frame->frame_id,
                          audio_frame->data.size()));

[imcheng, 2014-05-09 17:31:18]

The CQ bit was checked by imcheng@chromium.org

[commit-bot: I haz the power, 2014-05-09 17:35:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/imcheng@chromium.org/270493003/60001

[commit-bot: I haz the power, 2014-05-10 01:50:00]

Change committed as 269473