Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: media/cast/logging/logging_raw.cc

Issue 270493003: Cast: Deduplicate event types in cast library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/cast/logging/logging_raw.h ('k') | media/cast/logging/logging_raw_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/cast/logging/logging_raw.h" 5 #include "media/cast/logging/logging_raw.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
11 11
12 namespace media { 12 namespace media {
13 namespace cast { 13 namespace cast {
14 14
15 LoggingRaw::LoggingRaw() {} 15 LoggingRaw::LoggingRaw() {}
16 16
17 LoggingRaw::~LoggingRaw() {} 17 LoggingRaw::~LoggingRaw() {}
18 18
19 void LoggingRaw::InsertFrameEvent(const base::TimeTicks& time_of_event, 19 void LoggingRaw::InsertFrameEvent(const base::TimeTicks& time_of_event,
20 CastLoggingEvent event, uint32 rtp_timestamp, 20 CastLoggingEvent event,
21 EventMediaType event_media_type,
22 uint32 rtp_timestamp,
21 uint32 frame_id) { 23 uint32 frame_id) {
22 InsertBaseFrameEvent(time_of_event, event, frame_id, rtp_timestamp, 24 InsertBaseFrameEvent(time_of_event, event, event_media_type, frame_id,
23 base::TimeDelta(), 0, false, 0); 25 rtp_timestamp, base::TimeDelta(), 0, false, 0);
24 } 26 }
25 27
26 void LoggingRaw::InsertEncodedFrameEvent(const base::TimeTicks& time_of_event, 28 void LoggingRaw::InsertEncodedFrameEvent(const base::TimeTicks& time_of_event,
27 CastLoggingEvent event, 29 CastLoggingEvent event,
30 EventMediaType event_media_type,
28 uint32 rtp_timestamp, uint32 frame_id, 31 uint32 rtp_timestamp, uint32 frame_id,
29 int size, bool key_frame, 32 int size, bool key_frame,
30 int target_bitrate) { 33 int target_bitrate) {
31 InsertBaseFrameEvent(time_of_event, event, frame_id, rtp_timestamp, 34 InsertBaseFrameEvent(time_of_event, event, event_media_type,
32 base::TimeDelta(), size, key_frame, target_bitrate); 35 frame_id, rtp_timestamp, base::TimeDelta(), size,
36 key_frame, target_bitrate);
33 } 37 }
34 38
35 void LoggingRaw::InsertFrameEventWithDelay(const base::TimeTicks& time_of_event, 39 void LoggingRaw::InsertFrameEventWithDelay(const base::TimeTicks& time_of_event,
36 CastLoggingEvent event, 40 CastLoggingEvent event,
41 EventMediaType event_media_type,
37 uint32 rtp_timestamp, 42 uint32 rtp_timestamp,
38 uint32 frame_id, 43 uint32 frame_id,
39 base::TimeDelta delay) { 44 base::TimeDelta delay) {
40 InsertBaseFrameEvent(time_of_event, event, frame_id, rtp_timestamp, delay, 45 InsertBaseFrameEvent(time_of_event, event, event_media_type, frame_id,
41 0, false, 0); 46 rtp_timestamp, delay, 0, false, 0);
42 } 47 }
43 48
44 void LoggingRaw::InsertBaseFrameEvent(const base::TimeTicks& time_of_event, 49 void LoggingRaw::InsertBaseFrameEvent(const base::TimeTicks& time_of_event,
45 CastLoggingEvent event, uint32 frame_id, 50 CastLoggingEvent event,
51 EventMediaType event_media_type,
52 uint32 frame_id,
46 uint32 rtp_timestamp, 53 uint32 rtp_timestamp,
47 base::TimeDelta delay, int size, 54 base::TimeDelta delay, int size,
48 bool key_frame, int target_bitrate) { 55 bool key_frame, int target_bitrate) {
49 FrameEvent frame_event; 56 FrameEvent frame_event;
50 frame_event.rtp_timestamp = rtp_timestamp; 57 frame_event.rtp_timestamp = rtp_timestamp;
51 frame_event.frame_id = frame_id; 58 frame_event.frame_id = frame_id;
52 frame_event.size = size; 59 frame_event.size = size;
53 frame_event.timestamp = time_of_event; 60 frame_event.timestamp = time_of_event;
54 frame_event.type = event; 61 frame_event.type = event;
62 frame_event.media_type = event_media_type;
55 frame_event.delay_delta = delay; 63 frame_event.delay_delta = delay;
56 frame_event.key_frame = key_frame; 64 frame_event.key_frame = key_frame;
57 frame_event.target_bitrate = target_bitrate; 65 frame_event.target_bitrate = target_bitrate;
58 for (std::vector<RawEventSubscriber*>::const_iterator it = 66 for (std::vector<RawEventSubscriber*>::const_iterator it =
59 subscribers_.begin(); 67 subscribers_.begin();
60 it != subscribers_.end(); ++it) { 68 it != subscribers_.end(); ++it) {
61 (*it)->OnReceiveFrameEvent(frame_event); 69 (*it)->OnReceiveFrameEvent(frame_event);
62 } 70 }
63 } 71 }
64 72
65 void LoggingRaw::InsertPacketEvent(const base::TimeTicks& time_of_event, 73 void LoggingRaw::InsertPacketEvent(const base::TimeTicks& time_of_event,
66 CastLoggingEvent event, uint32 rtp_timestamp, 74 CastLoggingEvent event,
75 EventMediaType event_media_type,
76 uint32 rtp_timestamp,
67 uint32 frame_id, uint16 packet_id, 77 uint32 frame_id, uint16 packet_id,
68 uint16 max_packet_id, size_t size) { 78 uint16 max_packet_id, size_t size) {
69 PacketEvent packet_event; 79 PacketEvent packet_event;
70 packet_event.rtp_timestamp = rtp_timestamp; 80 packet_event.rtp_timestamp = rtp_timestamp;
71 packet_event.frame_id = frame_id; 81 packet_event.frame_id = frame_id;
72 packet_event.max_packet_id = max_packet_id; 82 packet_event.max_packet_id = max_packet_id;
73 packet_event.packet_id = packet_id; 83 packet_event.packet_id = packet_id;
74 packet_event.size = size; 84 packet_event.size = size;
75 packet_event.timestamp = time_of_event; 85 packet_event.timestamp = time_of_event;
76 packet_event.type = event; 86 packet_event.type = event;
87 packet_event.media_type = event_media_type;
77 for (std::vector<RawEventSubscriber*>::const_iterator it = 88 for (std::vector<RawEventSubscriber*>::const_iterator it =
78 subscribers_.begin(); 89 subscribers_.begin();
79 it != subscribers_.end(); ++it) { 90 it != subscribers_.end(); ++it) {
80 (*it)->OnReceivePacketEvent(packet_event); 91 (*it)->OnReceivePacketEvent(packet_event);
81 } 92 }
82 } 93 }
83 94
84 void LoggingRaw::AddSubscriber(RawEventSubscriber* subscriber) { 95 void LoggingRaw::AddSubscriber(RawEventSubscriber* subscriber) {
85 DCHECK(subscriber); 96 DCHECK(subscriber);
86 DCHECK(std::find(subscribers_.begin(), subscribers_.end(), subscriber) == 97 DCHECK(std::find(subscribers_.begin(), subscribers_.end(), subscriber) ==
87 subscribers_.end()); 98 subscribers_.end());
88 99
89 subscribers_.push_back(subscriber); 100 subscribers_.push_back(subscriber);
90 } 101 }
91 102
92 void LoggingRaw::RemoveSubscriber(RawEventSubscriber* subscriber) { 103 void LoggingRaw::RemoveSubscriber(RawEventSubscriber* subscriber) {
93 DCHECK(subscriber); 104 DCHECK(subscriber);
94 DCHECK(std::find(subscribers_.begin(), subscribers_.end(), subscriber) != 105 DCHECK(std::find(subscribers_.begin(), subscribers_.end(), subscriber) !=
95 subscribers_.end()); 106 subscribers_.end());
96 107
97 subscribers_.erase( 108 subscribers_.erase(
98 std::remove(subscribers_.begin(), subscribers_.end(), subscriber), 109 std::remove(subscribers_.begin(), subscribers_.end(), subscriber),
99 subscribers_.end()); 110 subscribers_.end());
100 } 111 }
101 112
102 } // namespace cast 113 } // namespace cast
103 } // namespace media 114 } // namespace media
OLDNEW
« no previous file with comments | « media/cast/logging/logging_raw.h ('k') | media/cast/logging/logging_raw_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698