Downloads Home - Offline page progress support

Downloads Home - Offline page progress support

Add support for in-progress offline pages in downloads home.  This means
propagating status to determine whether or not a download is completed
and whether or not it is paused.  This also means adding support for
pause, resume, and cancel support as well.

This CL just bridges the UX to the OfflinePage bridge.

BUG=658246
Review-Url: https://codereview.chromium.org/2704853002
Cr-Commit-Position: refs/heads/master@{#453529}
Committed: https://chromium.googlesource.com/chromium/src/+/27809c875f0856484aeb26e7378e68f8569f325b

[David Trainor- moved to gerrit, 2017-02-18 05:38:56]

dtrainor@chromium.org changed reviewers:
+ dfalcantara@chromium.org, dimich@chromium.org

[David Trainor- moved to gerrit, 2017-02-18 05:38:57]

ptal.  I still need to test this (can't from home), but it seems straightforward
enough to send out for now.

Thanks!

[David Trainor- moved to gerrit, 2017-02-18 05:39:05]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-18 05:39:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 06:04:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 06:04:24]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[David Trainor- moved to gerrit, 2017-02-18 16:51:49]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-18 16:51:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 17:25:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 17:25:48]

Dry run: This issue passed the CQ dry run.

[gone, 2017-02-21 18:29:12]

straightforward l.g.t.m.  ping me in office so I can see it in person and such

[Dmitry Titov, 2017-02-21 18:36:42]

lgtm from offline pages

[Dmitry Titov, 2017-02-28 01:17:33]

One nit:

https://codereview.chromium.org/2704853002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
(right):

https://codereview.chromium.org/2704853002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java:520:
mBackendProvider.getOfflinePageBridge().resumeDownload(getId());
resumeDownload -> cancelDownload

[gone, 2017-02-28 04:03:11]

Looks like it's working, based on the screenshots in the email thread.  lgtm

[David Trainor- moved to gerrit, 2017-02-28 04:03:42]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 04:04:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 05:39:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 05:39:06]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2017-02-28 06:41:32]

https://codereview.chromium.org/2704853002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
(right):

https://codereview.chromium.org/2704853002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java:520:
mBackendProvider.getOfflinePageBridge().resumeDownload(getId());
On 2017/02/28 01:17:33, Dmitry Titov wrote:
> resumeDownload -> cancelDownload

Gah thanks!  My bad.

[David Trainor- moved to gerrit, 2017-02-28 06:41:37]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2017-02-28 06:41:37]

The patchset sent to the CQ was uploaded after l-g-t-m from dimich@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2704853002/#ps40001
(title: "Fixed wrong function call")

[commit-bot: I haz the power, 2017-02-28 06:42:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 06:46:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488264097104580,
"parent_rev": "93059beb223bdcd86ed5b157ca1fb0fac8b5f665", "commit_rev":
"27809c875f0856484aeb26e7378e68f8569f325b"}

[commit-bot: I haz the power, 2017-02-28 06:47:12]

Description was changed from

==========
Downloads Home - Offline page progress support

Add support for in-progress offline pages in downloads home.  This means
propagating status to determine whether or not a download is completed
and whether or not it is paused.  This also means adding support for
pause, resume, and cancel support as well.

This CL just bridges the UX to the OfflinePage bridge.

BUG=658246
==========

to

==========
Downloads Home - Offline page progress support

Add support for in-progress offline pages in downloads home.  This means
propagating status to determine whether or not a download is completed
and whether or not it is paused.  This also means adding support for
pause, resume, and cancel support as well.

This CL just bridges the UX to the OfflinePage bridge.

BUG=658246

Review-Url: https://codereview.chromium.org/2704853002
Cr-Commit-Position: refs/heads/master@{#453529}
Committed:
https://chromium.googlesource.com/chromium/src/+/27809c875f0856484aeb26e7378e...
==========

[commit-bot: I haz the power, 2017-02-28 06:47:13]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/27809c875f0856484aeb26e7378e...