Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2704843002: [Predator] Add TouchCrashedDirectory feature. (Closed)

Created:
3 years, 10 months ago by Sharu Jiang
Modified:
3 years, 10 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org, inferno, stgao
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+648 lines, -228 lines) Patch
M appengine/findit/crash/chrome_crash_data.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M appengine/findit/crash/clusterfuzz_data.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M appengine/findit/crash/crash_data.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A appengine/findit/crash/crash_match.py View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M appengine/findit/crash/crash_util.py View 2 chunks +68 lines, -1 line 0 comments Download
M appengine/findit/crash/findit_for_chromecrash.py View 2 chunks +6 lines, -2 lines 0 comments Download
M appengine/findit/crash/findit_for_clusterfuzz.py View 2 chunks +6 lines, -2 lines 0 comments Download
M appengine/findit/crash/loglinear/changelist_classifier.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M appengine/findit/crash/loglinear/changelist_features/min_distance.py View 9 chunks +55 lines, -51 lines 0 comments Download
M appengine/findit/crash/loglinear/changelist_features/test/min_distance_test.py View 9 chunks +85 lines, -45 lines 0 comments Download
M appengine/findit/crash/loglinear/changelist_features/test/top_frame_index_test.py View 2 chunks +14 lines, -11 lines 0 comments Download
A appengine/findit/crash/loglinear/changelist_features/test/touch_crashed_directory_test.py View 1 chunk +90 lines, -0 lines 0 comments Download
M appengine/findit/crash/loglinear/changelist_features/test/touch_crashed_file_meta_test.py View 2 chunks +3 lines, -3 lines 0 comments Download
M appengine/findit/crash/loglinear/changelist_features/test/touch_crashed_file_test.py View 2 chunks +17 lines, -13 lines 0 comments Download
M appengine/findit/crash/loglinear/changelist_features/top_frame_index.py View 1 chunk +11 lines, -12 lines 0 comments Download
A appengine/findit/crash/loglinear/changelist_features/touch_crashed_directory.py View 1 2 1 chunk +114 lines, -0 lines 0 comments Download
M appengine/findit/crash/loglinear/changelist_features/touch_crashed_file.py View 1 2 chunks +10 lines, -10 lines 0 comments Download
M appengine/findit/crash/loglinear/changelist_features/touch_crashed_file_meta.py View 7 chunks +28 lines, -47 lines 0 comments Download
M appengine/findit/crash/predator.py View 1 1 chunk +5 lines, -6 lines 0 comments Download
M appengine/findit/crash/stacktrace.py View 1 chunk +0 lines, -14 lines 0 comments Download
M appengine/findit/crash/test/crash_util_test.py View 2 chunks +91 lines, -2 lines 0 comments Download
M appengine/findit/crash/test/predator_testcase.py View 1 chunk +0 lines, -1 line 0 comments Download
M appengine/findit/util_scripts/crash_queries/delta_test/delta_util.py View 1 2 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Sharu Jiang
PTAL.
3 years, 10 months ago (2017-02-22 02:14:19 UTC) #7
Sharu Jiang
Ping :)
3 years, 10 months ago (2017-02-22 22:33:20 UTC) #10
Martin Barbella
lgtm https://codereview.chromium.org/2704843002/diff/120001/appengine/findit/crash/loglinear/changelist_features/touch_crashed_directory.py File appengine/findit/crash/loglinear/changelist_features/touch_crashed_directory.py (right): https://codereview.chromium.org/2704843002/diff/120001/appengine/findit/crash/loglinear/changelist_features/touch_crashed_directory.py#newcode33 appengine/findit/crash/loglinear/changelist_features/touch_crashed_directory.py:33: touched_dir = (os.path.dirname(touched_file.new_path) if touched_file Do these paths ...
3 years, 10 months ago (2017-02-23 00:56:09 UTC) #11
Sharu Jiang
https://codereview.chromium.org/2704843002/diff/120001/appengine/findit/crash/loglinear/changelist_features/touch_crashed_directory.py File appengine/findit/crash/loglinear/changelist_features/touch_crashed_directory.py (right): https://codereview.chromium.org/2704843002/diff/120001/appengine/findit/crash/loglinear/changelist_features/touch_crashed_directory.py#newcode33 appengine/findit/crash/loglinear/changelist_features/touch_crashed_directory.py:33: touched_dir = (os.path.dirname(touched_file.new_path) if touched_file On 2017/02/23 00:56:09, Martin ...
3 years, 10 months ago (2017-02-23 02:01:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704843002/180001
3 years, 10 months ago (2017-02-23 21:02:05 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 21:11:11 UTC) #20
Message was sent while issue was closed. 
Committed patchset #3 (id:180001) as
https://chromium.googlesource.com/infra/infra/+/73f7382373f97e99b4ea470e91c87...

Powered by Google App Engine
This is Rietveld 408576698